From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: vc-modify-change-comment for "modern" backend fix Date: Wed, 18 May 2022 02:20:59 +0300 Message-ID: <45226141-ef02-656b-e99a-2ca53c91d2f2@yandex.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40560"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Cc: emacs-devel@gnu.org To: "Alfred M. Szmidt" , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 18 01:22:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nr6Wb-000APZ-1j for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 01:22:45 +0200 Original-Received: from localhost ([::1]:48662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nr6WZ-0005RA-NI for ged-emacs-devel@m.gmane-mx.org; Tue, 17 May 2022 19:22:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nr6V2-0004Un-3j for emacs-devel@gnu.org; Tue, 17 May 2022 19:21:08 -0400 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:42650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nr6Uy-0007mE-NE; Tue, 17 May 2022 19:21:07 -0400 Original-Received: by mail-wm1-x32b.google.com with SMTP id r6-20020a1c2b06000000b00396fee5ebc9so148074wmr.1; Tue, 17 May 2022 16:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Xk2okhphiytlSM7AW79XZUDGcXg3nmkmOunvZucFWYE=; b=lqsjsoIUukUdJljqiIir2oq2HX5gfPEVQkBPN7hLUqsfZFzUEOw2p7XY/YjRE9DKgB N2ezihOd0HTFvK6NeFUEPO+3BXX/67wUoLD3NsSrBoiVI1RAHWKb7A4fU/7NRJLqMpnL TBUO6+d9i+/v6EpCVbMhRaZCiUwLxIbHq4HpG6T+jAsN8b+PDBS3lQ4mJP0hTP/NMGj4 AEZLvXiZRwdOaA1V0D+4EI7MIbsOo7cV3vj8IDubYS+awPeX4fEwX2v3Lgfiy5dGKg/Y m7l9QYfudRDv7ZrY7t9QWJhrhRujGn5xMNSYO3Iy9jrYKus5Wx5o+tSe3Ses/hKlg9zo brYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Xk2okhphiytlSM7AW79XZUDGcXg3nmkmOunvZucFWYE=; b=8GwiXm7W8oIjzL9RNQjm/0+u0lvPypYws3I1GByzMKbaoE+C66ncfmfM7z6mOwEWw0 ENDZGPEhh4zPKS7GXqjr9TFjt9ePWPd6gayyZok34eiaIVEjcbEpImE11ZcpCVNm9Tjw 2Vqmdm5WKsj8bXxD02WUtUoqvz2AbhyboXeGMZ/p454BYin+lpFJfBG4KlFUggVfFRTr KFnes8cpV5kbgnTsAY6a8XIoXVWflGINnbg0Y48sIR+DeMPl2+gJww9HLVwTlZiUNWhC ylpwbIZ6SRsV52JVYEcu6/nCfaH+TIjWaMaGK2JEnPNYz7fvq0P/5qrhwFfLxrb1wnuZ ZxPw== X-Gm-Message-State: AOAM531tC4V3yeAsd7rg06AN4evOX3VrjrFKZuDTQtn0Vz3fWT8VBSue TMaKvGj+o8eOQk5giz4Gfob9fW8GXJw= X-Google-Smtp-Source: ABdhPJz58n7a0GKMpI7l/VRrb8kcg1RMm3oXKyaMj3Cx+OL1lzYyHrj12T7/hQWXn57ItXmP0cf8rw== X-Received: by 2002:a1c:38c6:0:b0:392:a4f2:20b1 with SMTP id f189-20020a1c38c6000000b00392a4f220b1mr23490386wma.7.1652829661958; Tue, 17 May 2022 16:21:01 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o23-20020a05600c511700b0039456c00ba7sm3955127wms.1.2022.05.17.16.21.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 16:21:01 -0700 (PDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289895 Archived-At: On 17.05.2022 22:10, Alfred M. Szmidt wrote: > Thanks Eli, and Stefan. > > Note that maybe you don't want "just the commit message text" because > you may want to preserve extra info such as the `Author:`. > > There is I think a very deep hole -- creation time, author, committer, > branch colour, etc, etc, etc. As it is now, modify-change-comment is > quite specific in what it wants to do. The command could return the contents of the log-edit buffer, including the recognized headers, which currently include, for Git, Author, Date, No-Verify and Sign-Off. There's also "Amend", and you may or may not reuse it to implement this functionality. Depending on whether you intend to support editing of older commits (not just the tip one).