unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Daniel Colascione" <dancol@dancol.org>
To: "Daniel Colascione" <dancol@dancol.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c
Date: Sat, 19 Jan 2019 13:35:29 -0800	[thread overview]
Message-ID: <4508562eb2e3fe5fedd01263f6c39d5c.squirrel@dancol.org> (raw)
In-Reply-To: <034912a4e687ae39bfc17b45ec6a9ef7.squirrel@dancol.org>

>> branch: master
>> commit 8e2b2a2b179c3ed170ad9de32a320e788c6a3a5e
>> Author: Eli Zaretskii <eliz@gnu.org>
>> Commit: Eli Zaretskii <eliz@gnu.org>
>>
>>     Minor cleanup in pdumper.c
>>
>>     * src/pdumper (subtract_timespec): Function removed.
>>     (pdumper_load): Use timespec_sub instead of subtract_timespec.
>> ---
>>  src/pdumper.c | 16 +++++-----------
>>  1 file changed, 5 insertions(+), 11 deletions(-)
>>
>> diff --git a/src/pdumper.c b/src/pdumper.c
>> index b51a379..1c49167 100644
>> --- a/src/pdumper.c
>> +++ b/src/pdumper.c
>> @@ -5388,15 +5388,6 @@ enum dump_section
>>     NUMBER_DUMP_SECTIONS,
>>    };
>>
>> -/* Subtract two timespecs, yielding a difference in milliseconds. */
>> -static double
>> -subtract_timespec (struct timespec minuend, struct timespec subtrahend)
>
> Cmon, don't you think we should do better than open-code timespec
> operations?

Ah, never mind. I saw the constants at the end of the patch and jumped the
gun.




  reply	other threads:[~2019-01-19 21:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190119182259.26893.32117@vcs0.savannah.gnu.org>
     [not found] ` <20190119182301.0DE562043D@vcs0.savannah.gnu.org>
2019-01-19 21:33   ` [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c Daniel Colascione
2019-01-19 21:35     ` Daniel Colascione [this message]
2019-01-19 21:53       ` Paul Eggert
2019-01-19 21:56         ` Daniel Colascione
2019-01-19 22:41           ` Paul Eggert
2019-01-20  3:44             ` Eli Zaretskii
2019-01-21 20:49               ` Paul Eggert
2019-01-21 22:46                 ` Daniel Colascione
2019-01-22  7:24                   ` Paul Eggert
2019-01-22 16:53                     ` Eli Zaretskii
2019-01-23  1:29                       ` Daniel Colascione
2019-01-23 22:07                         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4508562eb2e3fe5fedd01263f6c39d5c.squirrel@dancol.org \
    --to=dancol@dancol.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).