unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org, rms@gnu.org, storm@cua.dk
Subject: Re: jit-lock timer etc.
Date: Thu, 24 Aug 2006 18:18:31 +0200	[thread overview]
Message-ID: <44EDD157.8010207@gmx.at> (raw)
In-Reply-To: <87k64y8875.fsf@furball.mit.edu>

  I don't know what was wrong with this code since you didn't post it.
 > It looks like you simply forgot to initialize jit-lock-stealth-repeat-timer,
 > but I can't be sure.

As suggested by rms for his resume timer I did in `jit-lock-mode':

	 (when (and jit-lock-stealth-time (null jit-lock-stealth-timer))
	   (setq jit-lock-stealth-timer
		 (run-with-idle-timer jit-lock-stealth-time t
				      'jit-lock-stealth-fontify)))
  	 (when (and jit-lock-stealth-time (null jit-lock-stealth-repeat-timer))
  	   (setq jit-lock-stealth-repeat-timer (timer-create))
  	   (timer-set-function jit-lock-stealth-repeat-timer
  			       'jit-lock-stealth-fontify t))

 > However, the following patch, based on the last
 > patch you posted to this list with minimal modifications, works fine
 > for me.
 >
 > It applies to the current CVS tree, and uses `current-idle-time'.  It
 > includes and uses the change to `timer-set-idle-time' which I
 > previously posted, allowing it to accept the value returned by
 > `current-idle-time'.

Is this Richard's or Kim's version of `current-idle-time'.

 > I have verified that the idle timer triggers correctly, stops
 > correctly when user input comes in, and resumes when Emacs becomes
 > idle again.
 >
 >
 > *** emacs/lisp/jit-lock.el.~1.54.~	2006-08-17 11:49:36.000000000 -0400
 > --- emacs/lisp/jit-lock.el	2006-08-24 11:21:23.000000000 -0400
...
 > ! 	  (setq jit-lock-stealth-repeat-timer
 > ! 		(run-at-time delay
 > ! 			     nil 'jit-lock-stealth-fontify t)))))))

Richard told me not to use `run-at-time' - well it's for the first time
only - but I'll have to justify why I can't `run-with-idle-time' here.

 >   (defun timer-set-idle-time (timer secs &optional repeat)
 >     "Set the trigger idle time of TIMER to SECS.
 > + SECS may be an integer, floating point number, or the internal
 > + time format (HIGH LOW USECS) returned by, e.g., `current-time'.
 >   If optional third argument REPEAT is non-nil, make the timer
 >   fire each time Emacs is idle for that many seconds."
 >     (or (timerp timer)
 >         (error "Invalid timer"))
 > !   (if (consp secs)
 > !       (progn (aset timer 1 (car secs))
 > ! 	     (aset timer 2 (if (consp (cdr time)) (car (cdr time)) (cdr time)))
 > ! 	     (aset timer 3 (or (and (consp (cdr time)) (consp (cdr (cdr time)))
 > ! 				    (nth 2 time))
 > ! 			       0)))
 > !     (aset timer 1 0)
 > !     (aset timer 2 0)
 > !     (aset timer 3 0)
 > !     (timer-inc-time timer secs))
 >     (aset timer 4 repeat)
 >     timer)

Did you compile that?  `time' in here gets me:

In timer-set-idle-time:
timer.el:71:44:Warning: reference to free variable `time'

  parent reply	other threads:[~2006-08-24 16:18 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-21 11:12 jit-lock timer etc Richard Stallman
2006-08-21 11:39 ` Kim F. Storm
2006-08-21 16:57   ` martin rudalics
2006-08-21 18:51     ` Chong Yidong
2006-08-21 22:22       ` martin rudalics
2006-08-21 23:26         ` Chong Yidong
2006-08-22  7:18         ` Kim F. Storm
2006-08-22 15:41         ` Richard Stallman
2006-08-23 12:27           ` martin rudalics
2006-08-23 13:09             ` Kim F. Storm
2006-08-24  5:20               ` Richard Stallman
2006-08-24  7:47                 ` Kim F. Storm
2006-08-24  7:58                   ` Kim F. Storm
2006-08-24  9:07                     ` Kim F. Storm
2006-08-24 14:47                       ` Chong Yidong
2006-08-25 20:23                     ` Richard Stallman
2006-08-25 22:45                       ` Kim F. Storm
2006-08-25 20:23                   ` Richard Stallman
2006-08-25 21:27                     ` Chong Yidong
2006-08-26 12:22                       ` Richard Stallman
2006-08-24  9:10               ` Kim F. Storm
2006-08-24 12:23                 ` martin rudalics
2006-08-24 12:54                   ` Kim F. Storm
2006-08-24 13:07                   ` Kim F. Storm
2006-08-24 13:11                     ` Kim F. Storm
2006-08-24 13:34                       ` Kim F. Storm
2006-08-24 18:11                         ` martin rudalics
2006-08-24 20:11                           ` Kim F. Storm
2006-08-24 23:41                             ` Chong Yidong
2006-08-25  7:17                               ` Kim F. Storm
2006-08-24 14:16                     ` Chong Yidong
2006-08-24  5:20             ` Richard Stallman
2006-08-24  7:48               ` Kim F. Storm
2006-08-24 12:21               ` martin rudalics
2006-08-24 15:27             ` Chong Yidong
2006-08-24 15:40               ` Chong Yidong
2006-08-24 18:09                 ` martin rudalics
2006-08-24 19:16                   ` Stefan Monnier
2006-08-24 19:20                     ` Stefan Monnier
2006-08-24 16:18               ` martin rudalics [this message]
2006-08-24 16:34                 ` Chong Yidong
2006-08-24 19:48                 ` Chong Yidong
2006-08-25  6:00                   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44EDD157.8010207@gmx.at \
    --to=rudalics@gmx.at \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).