From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: Minimal patch: Use link face as default for button face Date: Sun, 25 Jun 2006 21:44:42 +0200 Message-ID: <449EE7AA.6000104@student.lu.se> References: <449E44B2.1040004@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1151264704 12788 80.91.229.2 (25 Jun 2006 19:45:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 25 Jun 2006 19:45:04 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 25 21:45:04 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FuaXU-0005Xu-GM for ged-emacs-devel@m.gmane.org; Sun, 25 Jun 2006 21:45:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FuaXU-00038M-1Q for ged-emacs-devel@m.gmane.org; Sun, 25 Jun 2006 15:45:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FuaXI-00038H-H8 for emacs-devel@gnu.org; Sun, 25 Jun 2006 15:44:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FuaXH-00036t-04 for emacs-devel@gnu.org; Sun, 25 Jun 2006 15:44:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FuaXG-00036l-Op for emacs-devel@gnu.org; Sun, 25 Jun 2006 15:44:46 -0400 Original-Received: from [81.228.8.164] (helo=pne-smtpout2-sn2.hy.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fuaix-00037T-9s; Sun, 25 Jun 2006 15:56:51 -0400 Original-Received: from [192.168.123.121] (83.249.218.244) by pne-smtpout2-sn2.hy.skanova.net (7.2.072.1) id 449A811D000846F2; Sun, 25 Jun 2006 21:44:42 +0200 User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) Original-To: Eli Zaretskii In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:56174 Archived-At: Eli Zaretskii wrote: >> Date: Sun, 25 Jun 2006 10:09:22 +0200 >> From: Lennart Borgman >> >> Now that there is a face called 'link should not this be used in button.el? >> >> >> diff -u -r1.21 button.el >> --- button.el 6 Feb 2006 14:33:32 -0000 1.21 >> +++ button.el 25 Jun 2006 08:07:32 -0000 >> @@ -52,9 +52,8 @@ >> ;; Globals >> >> ;; Use color for the MS-DOS port because it doesn't support underline. >> -(defface button '((((type pc) (class color)) >> - (:foreground "lightblue")) >> - (t :underline t)) >> +(defface button >> + '((t :inherit link)) >> "Default face used for buttons." >> :group 'basic-faces) >> > > This modifies the face default for (type pc). I don't think it's > time to change defaults now. > Would it not be better then to move this default to the face "link"? What is the benefit of not doing this now?