unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Emacs-Devel <emacs-devel@gnu.org>
Subject: Re: master 3ed79cd: Separate bytecode stack
Date: Sun, 13 Mar 2022 19:44:22 +0100	[thread overview]
Message-ID: <447E1D53-FA02-4776-9730-507BCA1993FA@acm.org> (raw)
In-Reply-To: <83lexdlpjy.fsf@gnu.org>

13 mars 2022 kl. 18.39 skrev Eli Zaretskii <eliz@gnu.org>:
> 
> This changeset causes compilation warning in a 32-bit build in which
> !LISP_WORDS_ARE_POINTERS and which was configured --with-wide-int:
> 
>  In file included from bytecode.c:22:
>  bytecode.c: In function 'sf_set_ptr':
>  bytecode.c:396:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>    396 |   fp[index] = XIL ((EMACS_INT)value);

Thank you for testing this configuration! Silly mistake of mine; please try with the pushed change.

> More generally, I'm quite nervous to see void * pointers and integers
> being put into the same array.

Actually what we are doing is storing arbitrary pointers in a Lisp_Object, and this should always be possible. In fact there is already a function for the conversion in one direction, XLP, but there isn't an XPL yet, which is what the code with the warning was doing. We could add an XPL to lisp.h; it would just be moving some code from bytecode.c.




  reply	other threads:[~2022-03-13 18:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-13 17:39 master 3ed79cd: Separate bytecode stack Eli Zaretskii
2022-03-13 18:44 ` Mattias Engdegård [this message]
2022-03-13 18:50   ` Eli Zaretskii
2022-03-14 15:56     ` Mattias Engdegård
2022-03-14 17:15       ` Eli Zaretskii
2022-03-15 14:20         ` Mattias Engdegård
2022-03-15 14:42           ` Eli Zaretskii
2022-03-15 15:08             ` Robert Pluim
2022-03-15 19:29             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=447E1D53-FA02-4776-9730-507BCA1993FA@acm.org \
    --to=mattiase@acm.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).