unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 3/3] RefTeX: Fix reftex-ref-style-toggle not properly deactivating.
@ 2013-05-15 18:10 Rüdiger Sonderfeld
  2013-05-23 15:39 ` Tassilo Horn
  0 siblings, 1 reply; 2+ messages in thread
From: Rüdiger Sonderfeld @ 2013-05-15 18:10 UTC (permalink / raw)
  To: auctex-devel; +Cc: emacs-devel

See documentation of `delete':

    Write `(setq foo (delete element foo))' to be sure of correctly
    changing the value of a sequence `foo'.

* lisp/textmodes/reftex.el (reftex-ref-style-toggle): Fix deactivate
  action.

Signed-off-by: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
---
 lisp/textmodes/reftex.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/textmodes/reftex.el b/lisp/textmodes/reftex.el
index 21083fd..7fed4d0 100644
--- a/lisp/textmodes/reftex.el
+++ b/lisp/textmodes/reftex.el
@@ -547,7 +547,7 @@ will deactivate it."
 	     (when (member style list)
 	       (setq reftex-tables-dirty t
 		     changed t)
-	       (delete style list)))
+	       (setq list (delete style list))))
 	    (t
 	     (if (member style list)
 		 (delete style list)
-- 
1.8.2.3


_______________________________________________
auctex-devel mailing list
auctex-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/auctex-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/3] RefTeX: Fix reftex-ref-style-toggle not properly deactivating.
  2013-05-15 18:10 [PATCH 3/3] RefTeX: Fix reftex-ref-style-toggle not properly deactivating Rüdiger Sonderfeld
@ 2013-05-23 15:39 ` Tassilo Horn
  0 siblings, 0 replies; 2+ messages in thread
From: Tassilo Horn @ 2013-05-23 15:39 UTC (permalink / raw)
  To: Rüdiger Sonderfeld; +Cc: auctex-devel, emacs-devel

Rüdiger Sonderfeld <ruediger@c-plusplus.de> writes:

> See documentation of `delete':
>
>     Write `(setq foo (delete element foo))' to be sure of correctly
>     changing the value of a sequence `foo'.
>
> * lisp/textmodes/reftex.el (reftex-ref-style-toggle): Fix deactivate
>   action.

Also committed, thanks!

Bye,
Tassilo

_______________________________________________
auctex-devel mailing list
auctex-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/auctex-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-23 15:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-15 18:10 [PATCH 3/3] RefTeX: Fix reftex-ref-style-toggle not properly deactivating Rüdiger Sonderfeld
2013-05-23 15:39 ` Tassilo Horn

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).