unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stuart D. Herring" <herring@lanl.gov>
To: "David Kastrup" <dak@gnu.org>
Cc: emacs-devel@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
	rms@gnu.org, "Kim F. Storm" <storm@cua.dk>
Subject: Re: `key-binding' and XEmacs-style events
Date: Sat, 3 Mar 2007 22:13:18 -0800 (PST)	[thread overview]
Message-ID: <44731.128.165.0.81.1172988798.squirrel@webmail.lanl.gov> (raw)
In-Reply-To: <85y7mg9hci.fsf@lola.goethe.zz>

> Is it documented anywhere that this a valid way to create a key
> sequence with modifiers?

See (elisp)Changing Key Bindings.

> Should we change EVENT_HAS_PARAMETERS itself maybe?  Or EVENTP?

As far as I can tell, this is the only place where it matters.  "Real"
events -- those that are generated by user input -- are never of this
form, since it's not the "real" representation.  (This is at least true
for keys; I don't know whether mouse events can have this structure, but
they can't very well be misclassified by the current macros!)  Even
`lookup-key' handles them properly; it's just the special code in
`key-binding' that needs to decide whether to intuit a position that
doesn't already support them.

I actually considered changing EVENT_HAS_PARAMETERS first, but decided
that (since I knew of no other bugs caused by it) it was safer and simpler
to just change the logic in the one place.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

  reply	other threads:[~2007-03-04  6:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28 22:57 `key-binding' and XEmacs-style events Stuart D. Herring
2007-03-01  8:14 ` Richard Stallman
2007-03-01 15:19   ` Stefan Monnier
2007-03-01 22:27     ` Stuart D. Herring
2007-03-01 23:35       ` Kim F. Storm
2007-03-01 23:52         ` Stuart D. Herring
2007-03-02  8:31           ` David Kastrup
2007-03-04  6:13             ` Stuart D. Herring [this message]
2007-03-02  8:26       ` Richard Stallman
2007-03-02  8:46         ` David Kastrup
2007-03-02 23:46           ` Richard Stallman
2007-03-03  7:40             ` David Kastrup
2007-03-04  2:00               ` Richard Stallman
2007-03-04  6:27                 ` Stuart D. Herring
2007-03-06 17:06           ` Stuart D. Herring
2007-03-02  8:28       ` David Kastrup
2007-03-02  3:28     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44731.128.165.0.81.1172988798.squirrel@webmail.lanl.gov \
    --to=herring@lanl.gov \
    --cc=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).