From: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: Dan Nicolaescu <dann@ics.uci.edu>, emacs-devel@gnu.org
Subject: Re: Problem report #33 RESOLVED
Date: Tue, 16 May 2006 08:16:05 +0200 [thread overview]
Message-ID: <44696E25.5000008@swipnet.se> (raw)
In-Reply-To: <m3r72vj703.fsf@kfs-l.imdomain.dk>
> What about the x_window_to_frame call in relation to Ghostview?
> If it can return NULL, emacs will crash...
>
It can return NULL if the window has been removed (i.e. it is a race problem).
Probably not that common in real life, but I think you should check in your fix.
Jan D.
>
> Index: xterm.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/xterm.c,v
> retrieving revision 1.912
> diff -c -r1.912 xterm.c
> *** xterm.c 14 May 2006 11:26:07 -0000 1.912
> --- xterm.c 15 May 2006 21:43:13 -0000
> ***************
> *** 5821,5826 ****
> --- 5821,5828 ----
> images, only, which should have 1 page. */
> Pixmap pixmap = (Pixmap) event.xclient.data.l[1];
> f = x_window_to_frame (dpyinfo, event.xclient.window);
> + if (!f)
> + goto OTHER;
> x_kill_gs_process (pixmap, f);
> expose_frame (f, 0, 0, 0, 0);
> goto done;
>
next prev parent reply other threads:[~2006-05-16 6:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-14 4:38 Problem report #33 Dan Nicolaescu
2006-05-14 11:03 ` Kim F. Storm
2006-05-14 11:31 ` Problem report #33 RESOLVED Jan D.
2006-05-15 21:46 ` Kim F. Storm
2006-05-16 6:16 ` Jan Djärv [this message]
2006-05-16 11:08 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44696E25.5000008@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).