From: "Jan D." <jan.h.d@swipnet.se>
Cc: emacs-devel@gnu.org
Subject: Re: Problem report #18 PENDING
Date: Sun, 14 May 2006 13:20:02 +0200 [thread overview]
Message-ID: <44671262.1080003@swipnet.se> (raw)
In-Reply-To: <200605132021.k4DKLHKL031275@amrm2.ics.uci.edu>
Dan Nicolaescu wrote:
> "Jan D." <jan.h.d@swipnet.se> writes:
>
> > Dan Nicolaescu wrote:
> > > "Jan D." <jan.h.d@swipnet.se> writes:
> > >
> > > > The thing is that the code assumes menu descriptions first have panes
> > > > and then items. In that case save_wv will always be != NULL (the /*
> > > > Create a new pane. */ branch). I don't know if it is possible to give
> > > > a description (in lisp) that only contains items. Maybe it is.
> > >
> > > Has anybody reached a conclusion about this issue?
> >
> > Richard installed a change in this code that fixed crashes people had
> > seen. I guess it was related to this. Anyway, the code now looks
> > different so I guess it is solved. The code does an abort now if an
> > item is not in a pane.
>
> Thanks. It seems that the report has changed too. Could you please
> look it over just to make sure that it's not pointing to a different
> issue?
>
> How about #26 and #27? You said they are the same as #18, are they OK
> now too? #19 is not reported anymore.
>
Yes, they are basically the same as 18, but with some different paths
being true and false.
> At conditional (8): "((0), (menu_items & -8))->contents[i] == Qt" taking false path
>
> 1808 else if (EQ (XVECTOR (menu_items)->contents[i], Qt))
> 1809 {
> 1810 /* Create a new pane. */
> 1811 Lisp_Object pane_name, prefix;
> 1812 char *pane_string;
> 1813
> 1814 panes_seen++;
> 1815
>
Ok, we are not taking this path, so panes_seen == 0.
> 1863 /* All items should be contained in panes. */
>
> At conditional (9): "panes_seen == 0" taking false path
>
> 1864 if (panes_seen == 0)
> 1865 abort ();
> 1866
>
And here suddenly it is assumed it is not 0. This can not happen. If
panes_seen != 0 save_wv can not be NULL.
Jan D.
prev parent reply other threads:[~2006-05-14 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 18:59 Problem report #18 Dan Nicolaescu
2006-04-10 20:04 ` Stuart D. Herring
2006-04-11 6:58 ` Problem report #18 PENDING Jan D.
2006-04-11 8:33 ` Sascha Wilde
2006-05-13 19:01 ` Dan Nicolaescu
2006-05-13 19:58 ` Jan D.
2006-05-13 20:21 ` Dan Nicolaescu
2006-05-14 11:20 ` Jan D. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44671262.1080003@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).