From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [package-vc] Consider cleaning up files from install process Date: Tue, 19 Sep 2023 07:19:21 -0500 Message-ID: <445b1a43-23a8-f6f3-08f6-82db6ed4adc6@alphapapa.net> References: <87il86lis7.fsf@breatheoutbreathe.in> <87h6nqbkmq.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22597"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Cc: Emacs Devel Mailing List To: Philip Kaludercic , Joseph Turner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 19 14:20:36 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiZiV-0005jS-DL for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Sep 2023 14:20:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiZhV-0002bG-OC; Tue, 19 Sep 2023 08:19:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiZhT-0002ax-Te for emacs-devel@gnu.org; Tue, 19 Sep 2023 08:19:32 -0400 Original-Received: from beige.elm.relay.mailchannels.net ([23.83.212.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiZhR-0005JT-T1 for emacs-devel@gnu.org; Tue, 19 Sep 2023 08:19:31 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8AAE7C1684; Tue, 19 Sep 2023 12:19:27 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a242.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0D9EDC212A; Tue, 19 Sep 2023 12:19:27 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1695125967; a=rsa-sha256; cv=none; b=j3afClZKR1Q8YpQYWSJQWAMHBPIqmKLRW3LkJyDN6ClCY/kUDjzeruMhvjzXZ5uU+YqywZ GclstNlXb/aQhYScTVjIAfKx6e1gTItDT8NooU3ZWf0RR158jPUcpCSCECJ/LfFoEcq/9d eOCJltMfRZVK10eU2/CClry30y3kiv/HydEe51ghgigCbQ6JdBkuXzLe74+0SwcWPIDBT/ rJloX13xuONDMPXfaIlvYX8IL9UycU/FPjH6R/nwZfleu0zApdqITxN44bH+1rytghzrbZ gsSBfJsG4euTBNDuM3QzfvglNUUtzFV/JJpW3M3T4rgPf7NArPsLyd1DIcEaFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1695125967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hUSTQ6Hknp89M+S+KuJK+YubBl1z5l1KQL0GjLoVNJI=; b=o5GKLSbaBY5xRQEz7cTu16N0RhcWpbxAkT7aYbL2XSL73CjG+rTT2Ico2PRhMXF7vsvueQ uHzGTknWfN859SQibHdyY0l9zAyR7EPJCtYzkf0z2OBg3P4GaT7xSpLjZLND+sjGtL1y0r YGHdX/HqdkL3KaxSOhwb67VfbCkuDlM4x46CfdQiXltrxsS9m2NfNGXU2ex1yDFwwq7gN7 lGVuSHEUt/zHC5fFA2QgEfzXTa8bxb43jcmdizK43GfawXmh6hQJZ4gEoGqC0VblkTHmtO YnIiryZu6tSl7XB1NnL0SisaLHK0rHuIU7ZOHxyqnAowP6aCIx8aVsui6LxZUA== ARC-Authentication-Results: i=1; rspamd-7d5dc8fd68-hnh49; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Lonely-Keen: 697896d86e4ce43a_1695125967335_791557276 X-MC-Loop-Signature: 1695125967335:842098240 X-MC-Ingress-Time: 1695125967335 Original-Received: from pdx1-sub0-mail-a242.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.119.184.198 (trex/6.9.1); Tue, 19 Sep 2023 12:19:27 +0000 Original-Received: from [10.66.0.178] (unknown [91.193.232.98]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a242.dreamhost.com (Postfix) with ESMTPSA id 4RqghG2xxcz4f; Tue, 19 Sep 2023 05:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1695125966; bh=hUSTQ6Hknp89M+S+KuJK+YubBl1z5l1KQL0GjLoVNJI=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=BxP/YaVyNofWxFEwQXHnUSEF9IfahiQbEhqxAbUlxdcRogExj4Dz0VVrm/KXZq9d3 RZkRZU8B50HPnYLVrvAQ97qoarB23/kcQbkSsgBhS9tmYO0WkwIMu0xlMz8vb19/k/ j3KbMx+FxZXarR/Ic8lY9IfgRXxbxf8SfHH1rYUo5tmikJpWmy5saIZ7X3+EgU0ApN EV2Zit15ap3Y1kv5/JsmpDke3i6SHs3UjBVAgEHLgD51jK2V4cfLHHPEUeWV4IGd8V 5K4zSYXjwRK4I9p6vYFSzc6yWyvqYPUfqOx6K2lT5c3PDWUHErJD3Z1FpKnVS4a78O 6zX+kT2EWv09g== Content-Language: en-US In-Reply-To: <87h6nqbkmq.fsf@posteo.net> Received-SPF: neutral client-ip=23.83.212.16; envelope-from=adam@alphapapa.net; helo=beige.elm.relay.mailchannels.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.473, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310752 Archived-At: I noticed this problem myself when I first tried using package-vc-install. An alternative would be to follow Quelpa's example: rather than loading the package directly from the git repository's directory, the package's files could be copied into a new directory in the elpa/ directory, and Emacs could load the package from there. As a developer, I would prefer that approach, because I don't usually want Emacs to load whatever commit I may have checked out in a package's repository. I want to install a commit of a package into my Emacs configuration and have that one loaded until I install a different one. In other words, the way package-vc-install currently works leaves me vulnerable to this scenario: 1. I use package-vc-install to install one of my packages from its local repository directory. 2. I check out a feature branch of that package to work on a new feature, saving some files but not loading any of the changed code. 3. I restart Emacs (e.g. maybe I shut down the system and turned it back on the next day). 4. That work-in-progress feature branch of my package gets loaded into Emacs automatically (which may be entirely broken, being a WIP). Whereas if I use Quelpa, it installs the files a package's recipe specifies into the expected location in the elpa/ directory, and that remains independent of whatever I may have checked out in the package's local git directory. My Emacs configuration and installed packages remain consistent regardless of whatever in-between state I may have left a package's repository in. Philip, would you be willing to consider switching to that model for package-vc-install, or offering it as an option? Thanks, Adam