From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: Problem report #25 Date: Tue, 11 Apr 2006 08:44:05 +0200 Message-ID: <443B5035.3030109@swipnet.se> References: <200604101858.k3AIwmQX005630@scanner2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1144737873 13495 80.91.229.2 (11 Apr 2006 06:44:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 Apr 2006 06:44:33 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 11 08:44:31 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FTCby-0000Tq-Fy for ged-emacs-devel@m.gmane.org; Tue, 11 Apr 2006 08:44:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FTCbx-0004kC-Uf for ged-emacs-devel@m.gmane.org; Tue, 11 Apr 2006 02:44:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FTCbh-0004iu-8L for emacs-devel@gnu.org; Tue, 11 Apr 2006 02:44:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FTCbf-0004iI-QC for emacs-devel@gnu.org; Tue, 11 Apr 2006 02:44:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FTCbf-0004iE-Hv for emacs-devel@gnu.org; Tue, 11 Apr 2006 02:44:07 -0400 Original-Received: from [213.50.74.197] (helo=smtp.operax.com) by monty-python.gnu.org with smtp (Exim 4.52) id 1FTCgT-0005LV-Ds for emacs-devel@gnu.org; Tue, 11 Apr 2006 02:49:05 -0400 Original-Received: (qmail 87140 invoked by uid 0); 11 Apr 2006 06:44:05 -0000 Original-Received: from dentan.operax.com (HELO ?192.168.1.48?) (192.168.1.48) by treo.operax.com with SMTP; 11 Apr 2006 06:44:05 -0000 User-Agent: Thunderbird 1.5 (X11/20051201) Original-To: emacs-devel@gnu.org In-Reply-To: <200604101858.k3AIwmQX005630@scanner2.ics.uci.edu> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52637 Archived-At: Dan Nicolaescu wrote: > CID: 25 Checker: FORWARD_NULL (help) File: emacs/src/xterm.c Function: > x_set_mouse_face_gc Description: Variable "face" tracked as NULL was passed > to a function that dereferences it. > > Event var_compare_op: Added "face" due to comparison "face == 0" Also see > events: [var_deref_op][var_deref_op][var_deref_model] At conditional (1): > "face == 0" taking true path > > 1064 if (face == NULL) > > At conditional (2): "9 < (((s)->f)->face_cache)->used" taking false path > > 1065 face = FACE_FROM_ID (s->f, MOUSE_FACE_ID); 1066 > The thing is that MOUSE_FACE_ID always exists on an X11 frame. It is realized at frame creation. So face can not be NULL after this. Jan D.