From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: esh-proc test failures Date: Tue, 30 Aug 2022 13:56:17 -0700 Message-ID: <43c8585e-54c3-7be0-683e-17320bcc3b92@gmail.com> References: <166036758418.2203.8730240669199078524@vcs2.savannah.gnu.org> <20220813051305.6667BC09BFE@vcs2.savannah.gnu.org> <87o7wmg0nx.fsf_-_@gnus.org> <30a7e3aa-ad52-325f-4fcd-528aade4a339@gmail.com> <838rng9kes.fsf@gnu.org> <837d2zae3m.fsf@gnu.org> <83v8qj8a2y.fsf@gnu.org> <83v8qj6iay.fsf@gnu.org> <40db52f2-86f1-3e86-fbca-80a8be09ee66@gmail.com> <6ca75c4c-adfc-fdde-cbff-6c76db036eab@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------62D2460332D3EF782F185991" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40794"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 22:57:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT8Iy-000ARH-KW for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 22:57:52 +0200 Original-Received: from localhost ([::1]:57188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT8Ix-0004IE-3g for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 16:57:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT8HX-0003JA-3U for emacs-devel@gnu.org; Tue, 30 Aug 2022 16:56:23 -0400 Original-Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:41893) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oT8HV-0001y3-Ct; Tue, 30 Aug 2022 16:56:22 -0400 Original-Received: by mail-pl1-x636.google.com with SMTP id p18so12259663plr.8; Tue, 30 Aug 2022 13:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id :references:cc:to:from:subject:from:to:cc; bh=GULq2Q5GtG4dpNpttZnh8RWuKv4D82VNdtKHO2gOHcE=; b=cM+aMVTt/7+N5uFSZVOLkP/Fy58OGin9p6oG8Ab/WW4e2KkZJdOHfteaVpnQjqmWta 40VMdjynCUYsxHjCusYBR9NLit77nRvj+YdpPzAL1VfhtM7ap79WeyQEPB07qyTa0So5 iHBEYndNzv6z3zYebOoagXZUNNjiX+Y7Jut1eSemTrsCGRye+cZDXuWauhzZO4NiXHW/ 7+MmGXTMZlx5L+1FY0ntajwbblhoaKck9/9KdC9PuY7Tzp1soEpEsrhT+sW2Ho9q1m+s RQ2adMSwODPO8L+k6PNNoG+SuD8UjOF+OOoIPGgOovb1DzYT7LQHXVC56ySxpRCgFktd te7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id :references:cc:to:from:subject:x-gm-message-state:from:to:cc; bh=GULq2Q5GtG4dpNpttZnh8RWuKv4D82VNdtKHO2gOHcE=; b=qXZgWb5YR3od43iQqWJZsDW7GsSL6Ct7qXTFHxSROmnOkNGeO5yGshn9adw9VLxi41 BfLV0Xsg66ahNUmLpTxgxPzdcqiy4J/XhPZ5vGljem6bJLBCYG5xWcp41bjaVdcJNwAm CE3yqihtMo2SQxB21YOiqukE6q+GZfn4elgcYxhxZb674edZMkBkqjOZNw2tXkh6cabQ hR6zxG7MNdWmBGZu4/ZfdA27MXpYduqlB32SX7i0sob574/mAHIexxOx61HGT67Tg10w m8z6w5HSqjHoCrzTtym89SC3ByZuVth2uW21seqJfadp6bdrlUTVCx6+wir0VK6HP9Z7 9R1Q== X-Gm-Message-State: ACgBeo0+iI4GksD0ktnJXSY27w8ogigi0QzfORPLrZAs9vu/ojSYzk6k 1mWvWrRTlVnYEouvackKzWTZCc8/9xg= X-Google-Smtp-Source: AA6agR4yt4JOI1Sw6mi6dhfSN7ZjslV8ieGaUSIE+vQ9SF1db0AJoEPXV6U406KzGn7R9WW335GNTw== X-Received: by 2002:a17:90b:38c6:b0:1f7:35d8:26e2 with SMTP id nn6-20020a17090b38c600b001f735d826e2mr87873pjb.168.1661892979684; Tue, 30 Aug 2022 13:56:19 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id e13-20020a170902ed8d00b0016d66d49b85sm6980319plj.239.2022.08.30.13.56.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 13:56:18 -0700 (PDT) In-Reply-To: <6ca75c4c-adfc-fdde-cbff-6c76db036eab@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294384 Archived-At: This is a multi-part message in MIME format. --------------62D2460332D3EF782F185991 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 8/30/2022 9:51 AM, Jim Porter wrote: > On 8/29/2022 8:18 PM, Jim Porter wrote: >> Merged as f9250c5ebc1730bf3bed4382549433f52f7ef9ca. Hopefully this >> fixes EMBA; if there are any further issues anyone encounters, just >> let me know. > > Apparently it doesn't. I've confirmed again locally that my patch does > fix *an* issue with 'eshell-pipe-broken', but I guess it's not the same > issue as what's on EMBA. I'll see if I can fix EMBA for real, or failing > that, we can disable the tests again. Ok, it looks like this is now failing only for native-comp builds. I think the patch I pushed *does* fix the bug, but the regression tests need a bit of extra help for native-comp builds. The attached diff should make it easier for others to see what's going on: with "slow-echo", Eshell will always print output after the "sh" subprocess has finished, triggering the bug. Then, we need to set 'debug-on-error' to nil in order to fix this for real. That's because Eshell uses 'condition-case-unless-debug' inside 'eshell-condition-case'. If anyone would like to test this out locally, just try out the diff with native-comp on or off and with/without the 'debug-on-error' overrides. However, I'm a bit concerned that there's another, more-general bug here. Why would native-comp and non-native-comp differ here? I think native-comp is doing the right thing, but maybe not... does anyone have any ideas here? In any case, assuming there are no objections, I'll merge a patch that just sets 'debug-on-error' to nil in the appropriate spots in esh-proc-tests.el in the next day or so. That should fix EMBA. --------------62D2460332D3EF782F185991 Content-Type: text/plain; charset=UTF-8; name="fix-tests-under-native-comp.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fix-tests-under-native-comp.diff" ZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoLXByb2MtdGVzdHMuZWwgYi90ZXN0 L2xpc3AvZXNoZWxsL2VzaC1wcm9jLXRlc3RzLmVsCmluZGV4IDIzNjliYjVjYzAuLjUxYzhm N2ZjYjggMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoLXByb2MtdGVzdHMuZWwK KysrIGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtcHJvYy10ZXN0cy5lbApAQCAtMjIsNiArMjIs NyBAQAogKHJlcXVpcmUgJ2VydCkKIChyZXF1aXJlICdlc2gtbW9kZSkKIChyZXF1aXJlICdl c2hlbGwpCisocmVxdWlyZSAnZW0tYmFzaWMpICAgICAgICAgICAgICAgICAgICAgOyBGSVhN RTogcmVtb3ZlIHRoaXMKIAogKHJlcXVpcmUgJ2VzaGVsbC10ZXN0cy1oZWxwZXJzCiAgICAg ICAgICAoZXhwYW5kLWZpbGUtbmFtZSAiZXNoZWxsLXRlc3RzLWhlbHBlcnMiCkBAIC0zNSw2 ICszNiwxNSBAQCBlc2gtcHJvYy10ZXN0LS1kZXRlY3QtcHR5LWNtZAogICAgICAgICAgICJp ZiBbIC10IDIgXTsgdGhlbiBlY2hvIHN0ZGVycjsgZmkiCiAgICAgICAgICAgIiciKSkKIAor OzsgRklYTUU6IHJlbW92ZSB0aGlzIGJlZm9yZSBjb21taXR0aW5nIHZ2dgorKGRlZnVuIGVz aGVsbC9zbG93LWVjaG8gKCZyZXN0IGFyZ3MpCisgICJBIHZlcnNpb24gb2YgYGVzaGVsbC9l Y2hvJyB0aGF0IHRha2VzIGEgd2hpbGUgdG8gcHJpbnQuIgorICAobGV0ICgodG90YWwgMCkp ICAgICAgICAgICAgICAgICAgICAgIDsgQnVzeS1sb29wIGZvciBhIHdoaWxlLgorICAgIChk b3RpbWVzIChpIDEwMDAwMDApCisgICAgICAoc2V0cSB0b3RhbCAoKyB0b3RhbCBpKSkpKQor ICAoZXNoZWxsL2VjaG8gYXJncykpCis7OyBGSVhNRTogcmVtb3ZlIHRoaXMgYmVmb3JlIGNv bW1pdHRpbmcgXl5eCisKIDs7OyBUZXN0czoKIAogKGVydC1kZWZ0ZXN0IGVzaC1wcm9jLXRl c3Qvc2lncGlwZS1leGl0cy1wcm9jZXNzICgpCkBAIC03NiwxNyArODYsMjMgQEAgZXNoLXBy b2MtdGVzdC9waXBlbGluZS1jb25uZWN0aW9uLXR5cGUvbWlkZGxlCiBwaXBlbGluZS4iCiAg IChza2lwLXVubGVzcyAoYW5kIChleGVjdXRhYmxlLWZpbmQgInNoIikKICAgICAgICAgICAg ICAgICAgICAgKGV4ZWN1dGFibGUtZmluZCAiY2F0IikpKQotICAoZXNoZWxsLWNvbW1hbmQt cmVzdWx0LWVxdWFsCi0gICAoY29uY2F0ICJlY2hvIHwgIiBlc2gtcHJvYy10ZXN0LS1kZXRl Y3QtcHR5LWNtZCAiIHwgY2F0IikKLSAgIG5pbCkpCisgIDs7IEFuIGBlc2hlbGwtcGlwZS1i cm9rZW4nIHNpZ25hbCBtaWdodCBvY2N1ciBpbnRlcm5hbGx5OyBsZXQgRXNoZWxsCisgIDs7 IGhhbmRsZSBpdCEKKyAgKGxldCAoKGRlYnVnLW9uLWVycm9yIG5pbCkpCisgICAgKGVzaGVs bC1jb21tYW5kLXJlc3VsdC1lcXVhbAorICAgICAoY29uY2F0ICJzbG93LWVjaG8gaGkgfCAi IGVzaC1wcm9jLXRlc3QtLWRldGVjdC1wdHktY21kICIgfCBjYXQiKQorICAgICBuaWwpKSkK IAogKGVydC1kZWZ0ZXN0IGVzaC1wcm9jLXRlc3QvcGlwZWxpbmUtY29ubmVjdGlvbi10eXBl L2xhc3QgKCkKICAgIlRlc3QgdGhhdCBvbmx5IG91dHB1dCBzdHJlYW1zIGFyZSBQVFlzIHdo ZW4gYSBjb21tYW5kIGVuZHMgYSBwaXBlbGluZS4iCiAgIChza2lwLXVubGVzcyAoZXhlY3V0 YWJsZS1maW5kICJzaCIpKQotICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LWVxdWFsCi0gICAo Y29uY2F0ICJlY2hvIHwgIiBlc2gtcHJvYy10ZXN0LS1kZXRlY3QtcHR5LWNtZCkKLSAgICh1 bmxlc3MgKGVxIHN5c3RlbS10eXBlICd3aW5kb3dzLW50KQotICAgICAic3Rkb3V0XG5zdGRl cnJcbiIpKSkKKyAgOzsgQW4gYGVzaGVsbC1waXBlLWJyb2tlbicgc2lnbmFsIG1pZ2h0IG9j Y3VyIGludGVybmFsbHk7IGxldCBFc2hlbGwKKyAgOzsgaGFuZGxlIGl0IQorICAobGV0ICgo ZGVidWctb24tZXJyb3IgbmlsKSkKKyAgICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LWVxdWFs CisgICAgIChjb25jYXQgInNsb3ctZWNobyBoaSB8ICIgZXNoLXByb2MtdGVzdC0tZGV0ZWN0 LXB0eS1jbWQpCisgICAgICh1bmxlc3MgKGVxIHN5c3RlbS10eXBlICd3aW5kb3dzLW50KQor ICAgICAgICJzdGRvdXRcbnN0ZGVyclxuIikpKSkKIAogKGVydC1kZWZ0ZXN0IGVzaC1wcm9j LXRlc3Qva2lsbC1waXBlbGluZSAoKQogICAiVGVzdCB0aGF0IGtpbGxpbmcgYSBwaXBlbGlu ZSBvZiBwcm9jZXNzZXMgb25seSBlbWl0cyBhIHNpbmdsZQo= --------------62D2460332D3EF782F185991--