From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Patch: blue underlined for button face and fill in apropos Date: Sat, 18 Feb 2006 23:40:56 +0100 Message-ID: <43F7A278.3020002@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070704040601080407020206" X-Trace: sea.gmane.org 1140303878 13299 80.91.229.2 (18 Feb 2006 23:04:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2006 23:04:38 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 19 00:04:36 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FAb7z-0008Ur-M0 for ged-emacs-devel@m.gmane.org; Sun, 19 Feb 2006 00:04:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FAb7y-0006Ja-Vy for ged-emacs-devel@m.gmane.org; Sat, 18 Feb 2006 18:04:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FAalA-00009i-MP for emacs-devel@gnu.org; Sat, 18 Feb 2006 17:41:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FAal8-00008q-NX for emacs-devel@gnu.org; Sat, 18 Feb 2006 17:41:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FAal8-00008K-5e for emacs-devel@gnu.org; Sat, 18 Feb 2006 17:40:58 -0500 Original-Received: from [81.228.11.98] (helo=pne-smtpout1-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FAaqn-0004JD-L2 for emacs-devel@gnu.org; Sat, 18 Feb 2006 17:46:49 -0500 Original-Received: from [192.168.123.121] (83.249.218.244) by pne-smtpout1-sn1.fre.skanova.net (7.2.070) id 43E9FE420029078E for emacs-devel@gnu.org; Sat, 18 Feb 2006 23:40:56 +0100 User-Agent: Thunderbird 1.5 (Windows/20051201) Original-To: Emacs Devel X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50723 Archived-At: This is a multi-part message in MIME format. --------------070704040601080407020206 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Here are some small patches I have not had time to propose before. The first one changes the color to blue for `button' face. This is the underlined face used in help. I have suggested this before, but without sending a patch. The second patch sets the default for `apropos-label-face' to `button' (above). It also adds filling of of values in the list shown by M-x apropos. I believe this makes the list more readable. --------------070704040601080407020206 Content-Type: text/plain; name="button-blue.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="button-blue.patch" Index: lisp/button.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/button.el,v retrieving revision 1.21 diff -c -r1.21 button.el *** lisp/button.el 6 Feb 2006 14:33:32 -0000 1.21 --- lisp/button.el 18 Feb 2006 22:30:37 -0000 *************** *** 54,60 **** ;; Use color for the MS-DOS port because it doesn't support underline. (defface button '((((type pc) (class color)) (:foreground "lightblue")) ! (t :underline t)) "Default face used for buttons." :group 'basic-faces) --- 54,60 ---- ;; Use color for the MS-DOS port because it doesn't support underline. (defface button '((((type pc) (class color)) (:foreground "lightblue")) ! (t :underline t :foreground "blue")) "Default face used for buttons." :group 'basic-faces) --------------070704040601080407020206 Content-Type: text/plain; name="apropos-button-and-fill.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="apropos-button-and-fill.patch" Index: lisp/apropos.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/apropos.el,v retrieving revision 1.114 diff -c -r1.114 apropos.el *** lisp/apropos.el 6 Feb 2006 14:33:31 -0000 1.114 --- lisp/apropos.el 18 Feb 2006 22:33:04 -0000 *************** *** 85,91 **** :group 'apropos :type 'face) ! (defcustom apropos-label-face 'italic "*Face for label (`Command', `Variable' ...) in Apropos output. A value of nil means don't use any special font for them, and also turns off mouse highlighting." --- 85,91 ---- :group 'apropos :type 'face) ! (defcustom apropos-label-face 'button "*Face for label (`Command', `Variable' ...) in Apropos output. A value of nil means don't use any special font for them, and also turns off mouse highlighting." *************** *** 980,994 **** (if (stringp (setq i (nth i apropos-item))) (progn (insert " ") ! (insert-text-button (button-type-get type 'apropos-label) ! 'type type ! ;; Can't use the default button face, since ! ;; user may have changed the variable! ! ;; Just say `no' to variables containing faces! ! 'face apropos-label-face ! 'apropos-symbol (car apropos-item)) ! (insert ": ") ! (insert (if do-keys (substitute-command-keys i) i)) (or (bolp) (terpri))))) --- 980,996 ---- (if (stringp (setq i (nth i apropos-item))) (progn (insert " ") ! (let ((start (point))) ! (insert-text-button (button-type-get type 'apropos-label) ! 'type type ! ;; Can't use the default button face, since ! ;; user may have changed the variable! ! ;; Just say `no' to variables containing faces! ! 'face apropos-label-face ! 'apropos-symbol (car apropos-item)) ! (insert ": ") ! (insert (if do-keys (substitute-command-keys i) i)) ! (fill-region start (point))) (or (bolp) (terpri))))) --------------070704040601080407020206 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --------------070704040601080407020206--