From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [rudalics@gmx.at: check_min_window_sizes] Date: Sat, 18 Feb 2006 12:10:19 +0100 Message-ID: <43F7009B.2070209@gmx.at> References: <87u0axpbba.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1140289648 5076 80.91.229.2 (18 Feb 2006 19:07:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2006 19:07:28 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 18 20:07:25 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FAXQS-0003Hg-FR for ged-emacs-devel@m.gmane.org; Sat, 18 Feb 2006 20:07:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FAXQR-0006dL-QV for ged-emacs-devel@m.gmane.org; Sat, 18 Feb 2006 14:07:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FAQ7F-0006Pb-5z for emacs-devel@gnu.org; Sat, 18 Feb 2006 06:19:05 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FAQ0q-0004Vl-0b for emacs-devel@gnu.org; Sat, 18 Feb 2006 06:12:31 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FAPzd-00048F-SI for emacs-devel@gnu.org; Sat, 18 Feb 2006 06:11:15 -0500 Original-Received: from [213.165.64.20] (helo=mail.gmx.net) by monty-python.gnu.org with smtp (Exim 4.52) id 1FAQ5C-0002IM-HE for emacs-devel@gnu.org; Sat, 18 Feb 2006 06:16:59 -0500 Original-Received: (qmail invoked by alias); 18 Feb 2006 11:11:11 -0000 Original-Received: from N838P009.adsl.highway.telekom.at (EHLO [62.47.48.169]) [62.47.48.169] by mail.gmx.net (mp035) with SMTP; 18 Feb 2006 12:11:11 +0100 X-Authenticated: #14592706 User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en Original-To: Chong Yidong In-Reply-To: <87u0axpbba.fsf@stupidchicken.com> X-Y-GMX-Trusted: 0 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50705 Archived-At: > This patch removes the bug. But I am not very familiar with the > window code, so if someone could check that this is correct, it'd be > great. Thanks for fixing this. A minor issue: When I now split a window with (progn (split-window-horizontally) (let ((window-min-width 1)) (shrink-window (1- (window-width)) t))) I get two windows where the left one has width 1 - I'm not sure whether windows with width 1 are valid as such. Evaluating (with-selected-window (split-window-horizontally) (let ((window-min-width 1)) (shrink-window (1- (window-width)) t))) the new window is deleted immediately. Hence the behavior has become asymmetric. Since you didn't change line 4091 of window.c the way you changed line 4067 that case is apparently handled in a different manner.