unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: "\"Augustin Chéneau (BTuin)\"" <btuin@mailo.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: New tree-sitter mode: bison-ts-mode
Date: Fri, 22 Sep 2023 01:45:43 -0700	[thread overview]
Message-ID: <43D0D3E5-C61C-4051-957F-8BA258074882@gmail.com> (raw)
In-Reply-To: <a15a1100-799e-4e18-8a4b-c0d7b8cdacaf@mailo.com>



> On Sep 21, 2023, at 1:15 PM, Augustin Chéneau (BTuin) <btuin@mailo.com> wrote:
> 
> Hello,
> I'd like to propose a new tree-sitter mode for Emacs, bison-ts-mode.
> This is a major mode for GNU Bison grammar files, and it supports the embedded languages C, C++ and Java.  Bison also supports D, but this language is not yet supported in Emacs so this mode does not support it either.
> 
> Since Bison is a superset of Yacc, it should work with Yacc without modification.
> The grammar is available here: <https://gitlab.com/btuin2/tree-sitter-bison>
> 
> This mode auto-detects the embedded language in the file if the directive "%language" is set.
> 
> 
> In addition of the mode, three patches are joined (should I open a bug report for those?).
> 
> 
> The first one is to add some missing rules in c-ts-mode.  Currently there is no rule if an identifier in a declaration is on a new line.
> In these two cases, "variable_name" is not indented:
> 
> static myttype *
> variable_name;
> 
> static myttype
> variable_name;
> 
> The new behavior is the same as c-mode.
> 
> 
> 
> The second one fix an edge case with multiple languages indentation. Here is a simple example:
> 
> // language_A
>    {
>       // language_B
>    }
> // language_A
> 
> 
> Here, brackets are managed by language_A, but everything inside is managed by language_B.  Meaning that if the pointer is at the beginning of the third line (with the closing bracket), it will use language_B's indent rules.  But if the point is located on the bracket, it will use language_A's rules.
> 
> 
> 
> The third patch simply extracts java-ts-mode's feature list in a variable, to allow to reuse it.
> 
> 
> Huge thanks to Yuan Fu for his help and his amazing work with tree-sitter.

Thanks!

For now, I think we can just use the same feature names for different languages (so no need for prefixes anymore). That way, enabling a feature in the feature list would enable it for all languages. If a user desires more fine-grained control, they can use treesit-recompute-feature to enable/disable features for a particular language. (I upgraded that function in 04fd8b173bd)

Yuan


  parent reply	other threads:[~2023-09-22  8:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 20:15 New tree-sitter mode: bison-ts-mode Augustin Chéneau (BTuin)
2023-09-21 22:23 ` Stefan Kangas
2023-09-22  5:52 ` Eli Zaretskii
2023-09-22 23:44   ` Yuan Fu
2023-09-23  5:52     ` Eli Zaretskii
2023-09-26  3:42       ` Yuan Fu
2023-09-22  7:38 ` Philip Kaludercic
2023-09-22 14:53   ` Augustin Chéneau (BTuin)
2023-09-22 20:40     ` Philip Kaludercic
2023-09-22 23:21       ` Augustin Chéneau (BTuin)
2023-09-22  7:42 ` Stefan Kangas
2023-09-22  8:45 ` Yuan Fu [this message]
2023-09-24 21:10 ` Yuan Fu
2023-09-26 11:52   ` Augustin Chéneau (BTuin)
2023-09-28  7:03     ` Yuan Fu
     [not found]       ` <b999a251-1778-49ac-90dc-ef8d78d36d53@mailo.com>
2023-09-29  1:26         ` Yuan Fu
2023-09-29 14:13       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43D0D3E5-C61C-4051-957F-8BA258074882@gmail.com \
    --to=casouri@gmail.com \
    --cc=btuin@mailo.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).