From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: Patch that adds help to isearch Date: Wed, 30 Nov 2005 09:24:52 +0100 Message-ID: <438D61D4.1040002@student.lu.se> References: <36dd4d936dd9fb.36dd9fb36dd4d9@net.lu.se> <87r78yswf4.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1133358265 14049 80.91.229.2 (30 Nov 2005 13:44:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2005 13:44:25 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 30 14:44:23 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EhPxY-0003Xp-75 for ged-emacs-devel@m.gmane.org; Wed, 30 Nov 2005 12:17:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EhPbZ-0003hA-Ks for ged-emacs-devel@m.gmane.org; Wed, 30 Nov 2005 05:54:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EhNKv-0002fD-Mn for emacs-devel@gnu.org; Wed, 30 Nov 2005 03:29:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EhNKr-0002eK-8k for emacs-devel@gnu.org; Wed, 30 Nov 2005 03:29:07 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EhNKo-0002de-Aj for emacs-devel@gnu.org; Wed, 30 Nov 2005 03:29:02 -0500 Original-Received: from [81.228.8.83] (helo=pne-smtpout1-sn2.hy.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EhNKk-00057a-J1; Wed, 30 Nov 2005 03:28:58 -0500 Original-Received: from [192.168.123.121] (83.249.218.244) by pne-smtpout1-sn2.hy.skanova.net (7.2.060.1) id 438C7D000002F6FB; Wed, 30 Nov 2005 09:24:53 +0100 User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en Original-To: Juri Linkov In-Reply-To: <87r78yswf4.fsf@jurta.org> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46805 Archived-At: Juri Linkov wrote: >>Thanks for the explanation about why C-h is needed for an >>experienced user. I think however that enabling the help only for >>the state when the search string is empty would be confusing. >>I would prefer a defcustom to enable/disable isearch-mode-help on >>C-h instead. Could that satisfy experienced users? >> >> > >A key definition is as simple as defcustom. Instead of: > >(setq isearch-bind-C-h-to-isearch-mode-help t) > >you can put in .emacs: > >(define-key map "\C-h" 'isearch-mode-help) > >The main question is what should be the default. For novices, who >don't know how to configure Emacs, the default binding of C-h to >`isearch-mode-help' is very helpful. More experienced users can >put in .emacs: > >(define-key isearch-mode-map "\C-h" nil) > >if C-h is bound to `isearch-mode-help' in isearch.el by default. > > Unfortunately you need a bit more to make it useful. In the patch I sent before I also added scrolling of the help buffer. Scrolling of the help buffer is done by the keys the user has bound to `scroll-other-window' and 'scroll-other-window-down'. It is only active when the other window is the help buffer. However the scrolling could of course be dependent on if C-h and f1 is bound to isearch-mode-help.A defcustom seems more easy to understand though.