From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: Bug in window resizing? Date: Thu, 24 Nov 2005 00:58:37 +0100 Message-ID: <4385022D.7000404@student.lu.se> References: <43296649.7000408@student.lu.se> <432D7C92.4090803@student.lu.se> <43790309.6080809@student.lu.se> <43792065.5010406@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1132790473 316 80.91.229.2 (24 Nov 2005 00:01:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 24 Nov 2005 00:01:13 +0000 (UTC) Cc: "Kim F. Storm" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 24 01:01:09 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ef4Vv-0006by-QH for ged-emacs-devel@m.gmane.org; Thu, 24 Nov 2005 00:59:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ef4Vu-0004C8-CO for ged-emacs-devel@m.gmane.org; Wed, 23 Nov 2005 18:58:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ef4Ve-00049p-Cf for emacs-devel@gnu.org; Wed, 23 Nov 2005 18:58:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ef4Vc-000493-O9 for emacs-devel@gnu.org; Wed, 23 Nov 2005 18:58:42 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ef4Vc-00048t-IK for emacs-devel@gnu.org; Wed, 23 Nov 2005 18:58:40 -0500 Original-Received: from [81.228.11.98] (helo=pne-smtpout1-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ef4Vb-0006Iz-Pt; Wed, 23 Nov 2005 18:58:40 -0500 Original-Received: from [192.168.123.121] (83.249.218.244) by pne-smtpout1-sn1.fre.skanova.net (7.2.060.1) id 4384D1D400009246; Thu, 24 Nov 2005 00:58:38 +0100 User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en Original-To: rms@gnu.org, emacs-devel@gnu.org In-Reply-To: <43792065.5010406@student.lu.se> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46493 Archived-At: Lennart Borgman wrote: > Kim F. Storm wrote: > >> Lennart Borgman writes: >> >> >> >>> Richard M. Stallman wrote: >>> >>> >>> >>>> What is needed (I believe) is to go up one level in the split >>>> tree, find the window under the selected window and then resize >>>> this. Or maybe it is even more complicated than that? >>>> >>>> Yes, I think you are right. It seems that the only feasible way to >>>> fix this is to make a new interface. Since that change is already >>>> being discussed, I think we should simply go ahead with that. >>>> >>>> Is anyone working on that? >>>> >>>> >>>> >>> >>> I think this bug is still there. You can see this bug if you first >>> split windows with C-x 2, C-x 3, C-x 2. Now try to move the bottom of >>> the second window to the left. >>> >>> Kim, did you look at this when you made `window-tree'? Or perhaps >>> could you look at it now? I do not think I understand the subtle >>> details here ;-) >>> >> >> >> I implemented window-tree for the purpose of balance-windows. >> I didn't correlate it to this problem. >> >> AFAICS, enlarge-window works just fine in that window (try C-x ^), so >> if the code in mouse-drag-mode-line-1 would just selected the proper >> window, it should work (without finding the parent window). >> >> > No, it does not work if you use (enlarge-window 1 nil t) in that > window. I did look at the C code before, see the sentence beginning > with "What is needed ... " above. I just think it is best I do not > touch this part of the C code. I have decided I can unfortunately not fix this bug now. A quite complicated rewrite of `enlarge-window' is needed. I run into this when I tried to finish the rewrite of `balance-windows'. I have written a new version of balance-windows and it works (I belieive) but since Kim's patch gave some new possibilities I wanted to enhance it a bit. The rewrite contains three functions: 1) A rewrite of balance-windows (at the moment called bw-balance, C-x + +) 2) A new function to balance only the siblings in the tree from `window-tree' (bw-balance-siblings, C-x + .) 3) A temporary mode for resizing current window with the arrow keys (started with C-x +) The bug in enlarge-window is more visible now because of 3 above. However if you try to resize using the mouse you see the same problem. Please test the new functions. They are in http://ourcomments.org/Emacs/DL/elisp/test/bwcvs.el