From: Theodor Thornhill <theo@thornhill.no>
To: Ergus <spacibba@aol.com>, Eli Zaretskii <eliz@gnu.org>
Cc: casouri@gmail.com, emacs-devel@gnu.org
Subject: Re: Missing features in c-ts-mode
Date: Fri, 17 Feb 2023 18:34:34 +0100 [thread overview]
Message-ID: <437CB8E1-1BBA-42A8-BADE-9F729A7AC5CA@thornhill.no> (raw)
In-Reply-To: <20230217163747.yt5kizq6e4vqmqqe@Ergus>
On 17 February 2023 17:37:47 CET, Ergus <spacibba@aol.com> wrote:
>Hi Eli and Theo:
>
>Yes, I know that the feature is not very "popular" to be enabled by
>default, but for parallel programming models based on pragmas (OpenMP,
>OmpSs, OpenACC) it is very important.
>
>Many people in my previous work moved to some other editor after years
>using emacs due to these apparently "small" details. Every time they
>wanted to indent a portion of code (i.e they added an if around it), all
>the pragmas moved out of their place and needed manual fix.
>
>On that moment I commented with Alan the possibility to make #pragma a
>syntactc symbol which we could control its indentation like anything
>else in c-mode (with +, ++, -, 0 or [0]). But he said that it required
>too many changes to implement that and offered this "toggle" solution
>good enough for me.
>
>I will open the feature request in a moment, but just wanted to comment
>the alternative solution more consistent and without an extra mode;
>because maybe that way may be simpler now in the new mode??
>
>Best,
>Ergus
>
>On Fri, Feb 17, 2023 at 02:20:59PM +0200, Eli Zaretskii wrote:
>>> From: Theodor Thornhill <theo@thornhill.no>
>>> Cc: Eli Zaretskii <eliz@gnu.org>, casouri@gmail.com, emacs-devel@gnu.org
>>> Date: Fri, 17 Feb 2023 10:56:28 +0100
>>>
>>> > #pragma parallel for first private(x) \
>>> > shared(y) etc
>>> > for (...) {
>>> > ....
>>> > }
>>> > }
>>> >
>>> > In this case the pragma in column zero is very confusing. Alan added a
>>> > new mode (c-toggle-cpp-indent-to-body) which worked around this issue a
>>> > few years ago. I don't if it is possible to enable similar behavior with
>>> > your change? Is is?
>>> >
>>> > Best,
>>> > Ergus
>>> >
>>>
>>> It's absolutely possible, but IMO that sounds like an improvement for
>>> emacs 30, maybe?
>>
>> It depends on how simple and safe the change will be. But yes, I'm
>> okay with delaying this to Emacs 30 if the addition is complex enough.
>>
>> Thanks.
>>
Would this mean you'd want all preproc directives configurable, or only some in particular? I think a defcustom for either/or is doable for Emacs 29, but for granular control we'd need to think a bit more.
c-ts-mode-preproc-indent-to-body?
next prev parent reply other threads:[~2023-02-17 17:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 17:59 Missing features in c-ts-mode Eli Zaretskii
2023-02-15 18:29 ` Theodor Thornhill
2023-02-15 19:05 ` Eli Zaretskii
2023-02-15 19:18 ` Theodor Thornhill
2023-02-15 19:31 ` Theodor Thornhill
2023-02-15 19:48 ` Eli Zaretskii
2023-02-15 19:59 ` Theodor Thornhill
2023-02-16 19:14 ` Theodor Thornhill
2023-02-16 20:38 ` Eli Zaretskii
2023-02-16 21:05 ` Theodor Thornhill
2023-02-17 8:29 ` Ergus
2023-02-17 8:42 ` Eli Zaretskii
2023-02-17 9:56 ` Theodor Thornhill
2023-02-17 12:20 ` Eli Zaretskii
2023-02-17 16:37 ` Ergus
2023-02-17 17:34 ` Theodor Thornhill [this message]
2023-02-17 18:02 ` Ergus
2023-02-17 18:10 ` Theodor Thornhill
2023-02-17 18:27 ` Ergus
2023-02-17 18:43 ` Theodor Thornhill
2023-02-15 20:31 ` Felix
2023-02-16 7:35 ` Eli Zaretskii
2023-02-16 8:08 ` Theodor Thornhill
2023-02-16 12:10 ` Felix
2023-02-15 20:03 ` Eli Zaretskii
2023-02-15 20:21 ` Theodor Thornhill
2023-02-16 7:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437CB8E1-1BBA-42A8-BADE-9F729A7AC5CA@thornhill.no \
--to=theo@thornhill.no \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).