Python fix for def and class highlighting

Python fix for def and class highlighting

[Nathaniel Flath]

[-- Attachment #1.1: Type: text/plain, Size: 304 bytes --]

In python-mode, def and class are not highlighted as keywords until the
function or class name is started.  The attached patch will highlight these
properly without requiring whitespace or a name afterwards.  This makes it
more like elisp-mode, java-mode, cc-mode, and js2-mode.

Thanks,
Nathaniel Flath

[-- Attachment #1.2: Type: text/html, Size: 320 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: python-highlighting.patch --]
[-- Type: text/x-patch; name="python-highlighting.patch", Size: 988 bytes --]

Index: python.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/python.el,v
retrieving revision 1.102
diff -u -r1.102 python.el
--- python.el	7 Dec 2009 20:06:31 -0000	1.102
+++ python.el	28 Dec 2009 19:50:30 -0000
@@ -106,9 +106,9 @@
     (,(rx symbol-start "None" symbol-end)	; see § Keywords in 2.5 manual
      . font-lock-constant-face)
     ;; Definitions
-    (,(rx symbol-start (group "class") (1+ space) (group (1+ (or word ?_))))
+    (,(rx symbol-start (group "class") (? (1+ space) (group (1+ (or word ?_)))))
      (1 font-lock-keyword-face) (2 font-lock-type-face))
-    (,(rx symbol-start (group "def") (1+ space) (group (1+ (or word ?_))))
+    (,(rx symbol-start (group "def") (? (1+ space) (group (1+ (or word ?_)))))
      (1 font-lock-keyword-face) (2 font-lock-function-name-face))
     ;; Top-level assignments are worth highlighting.
     (,(rx line-start (group (1+ (or word ?_))) (0+ space) "=")

Re: Python fix for def and class highlighting

[Nathaniel Flath]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Just throwing this out again.  Is there a more specific list I should email?

Thanks,
Nathaniel Flath

On Mon, Dec 28, 2009 at 2:51 PM, Nathaniel Flath <flat0103@gmail.com> wrote:

> In python-mode, def and class are not highlighted as keywords until the
> function or class name is started.  The attached patch will highlight these
> properly without requiring whitespace or a name afterwards.  This makes it
> more like elisp-mode, java-mode, cc-mode, and js2-mode.
>
> Thanks,
> Nathaniel Flath
>

[-- Attachment #2: Type: text/html, Size: 799 bytes --]

Re: Python fix for def and class highlighting

[Andreas Roehler]

Nathaniel Flath wrote:
> Just throwing this out again.  Is there a more specific list I should email?

AFAIK not. Seems core people are a little bit busy for the moment with switch to bazaar...
Maybe address the author?

Andreas



> 
> Thanks,
> Nathaniel Flath
> 
> On Mon, Dec 28, 2009 at 2:51 PM, Nathaniel Flath <flat0103@gmail.com
> <mailto:flat0103@gmail.com>> wrote:
> 
>     In python-mode, def and class are not highlighted as keywords until
>     the function or class name is started.  The attached patch will
>     highlight these properly without requiring whitespace or a name
>     afterwards.  This makes it more like elisp-mode, java-mode, cc-mode,
>     and js2-mode.
> 
>     Thanks,
>     Nathaniel Flath
> 
> 

Re: Python fix for def and class highlighting

[Davis Herring]

> Just throwing this out again.  Is there a more specific list I should
> email?
>
> Thanks,
> Nathaniel Flath

File it as a bug report.  Then it will (eventually) be seen without the
need for manual reminders.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.