From: Glenn Morris <rgm@gnu.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: emacs-devel@gnu.org
Subject: Re: vc-set-mode-line-busy-indicator
Date: Sat, 01 Mar 2008 17:53:34 -0500 [thread overview]
Message-ID: <434pbqcaz5.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <18377.55334.203888.524043@kahikatea.snap.net.nz> (Nick Roberts's message of "Sun, 2 Mar 2008 11:26:46 +1300")
Nick Roberts wrote:
> > Sorry, but now this is installed I see it is totally invisible on my
> > mode-line.
> >
> > Please can I either remove the 'face altogether or create a new face
> > for it. I don't care which.
>
> I committed it because that seemed to fit the culture being advocated. If it
> doesn't work for you then please do change it accordingly.
I don't know nothing' 'bout no culture...
I should have tried it out to see how it looked.
If people feel the need to emphasize certain mode-line features (and
if you did a similar thing for gud, there probably is such a need),
then I would say it needs a new face; because the mode-line palette is
different to the buffer palette.
I suggest a new `mode-line-emphasis' face. The existing
`mode-line-highlight' doesn't look right because it is designed for
buttons. I made up some defaults; I'm not sure about them.
*** faces.el.~1.394.~ 2008-02-23 11:24:00.000000000 -0800
--- faces.el 2008-03-01 14:47:47.000000000 -0800
***************
*** 2388,2398 ****
:box (:line-width 2 :color "grey40" :style released-button))
(t
:inherit highlight))
! "Basic mode line face for highlighting."
:version "22.1"
:group 'mode-line-faces
:group 'basic-faces)
(defface mode-line-buffer-id
'((t (:weight bold)))
"Face used for buffer identification parts of the mode line."
--- 2388,2409 ----
:box (:line-width 2 :color "grey40" :style released-button))
(t
:inherit highlight))
! "Basic mode line face for highlighting (of buttons, etc)."
:version "22.1"
:group 'mode-line-faces
:group 'basic-faces)
+ (defface mode-line-emphasis
+ '((((class color) (min-colors 88))
+ :background "grey40")
+ (t
+ :inherit highlight))
+ "Face used to emphasize certain mode line features.
+ Use the face `mode-line-highlight' for features that can be selected."
+ :version "23.1"
+ :group 'mode-line-faces
+ :group 'basic-faces)
+
(defface mode-line-buffer-id
'((t (:weight bold)))
"Face used for buffer identification parts of the mode line."
*** vc.el.~1.545.~ 2008-03-01 11:41:50.000000000 -0800
--- vc.el 2008-03-01 14:43:10.000000000 -0800
***************
*** 1063,1072 ****
(defun vc-set-mode-line-busy-indicator ()
(setq mode-line-process
! (propertize " [waiting...]"
! 'face 'font-lock-variable-name-face
'help-echo
! "A VC command is in progress in this buffer")))
(defun vc-exec-after (code)
"Eval CODE when the current buffer's process is done.
--- 1063,1072 ----
(defun vc-set-mode-line-busy-indicator ()
(setq mode-line-process
! (concat " " (propertize "[waiting...]"
! 'face 'mode-line-emphasis
'help-echo
! "A VC command is in progress in this buffer"))))
(defun vc-exec-after (code)
"Eval CODE when the current buffer's process is done.
next prev parent reply other threads:[~2008-03-01 22:53 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 12:46 vc-set-mode-line-busy-indicator Nick Roberts
2008-02-25 20:25 ` vc-set-mode-line-busy-indicator Nick Roberts
2008-02-26 4:11 ` vc-set-mode-line-busy-indicator Glenn Morris
2008-02-26 7:38 ` vc-set-mode-line-busy-indicator Nick Roberts
2008-03-01 22:19 ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-01 22:26 ` vc-set-mode-line-busy-indicator Nick Roberts
2008-03-01 22:53 ` Glenn Morris [this message]
2008-03-02 16:12 ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-03 1:57 ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-03 17:13 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-03 21:23 ` vc-set-mode-line-busy-indicator Nick Roberts
2008-03-03 23:27 ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-02 17:25 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-02 18:53 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-03 18:27 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-03 18:58 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-04 17:38 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-04 18:39 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-05 21:33 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-05 21:50 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-07 3:38 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-07 3:46 ` vc-set-mode-line-busy-indicator Miles Bader
2008-03-07 17:46 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-07 18:05 ` vc-set-mode-line-busy-indicator Jan Djärv
2008-03-07 18:50 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-07 22:18 ` vc-set-mode-line-busy-indicator Stefan Monnier
2008-03-08 7:03 ` vc-set-mode-line-busy-indicator Jan Djärv
2008-03-08 17:39 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-08 18:57 ` Diffs between %s and %s end here (was: vc-set-mode-line-busy-indicator) Reiner Steib
2008-03-08 19:29 ` Diffs between %s and %s end here David Kastrup
2008-03-08 19:35 ` Dan Nicolaescu
2008-03-08 19:40 ` David Kastrup
2008-03-08 21:33 ` Juri Linkov
2008-03-08 21:39 ` Glenn Morris
2008-03-08 21:59 ` Juri Linkov
2008-03-08 23:41 ` Glenn Morris
2008-03-08 23:58 ` David Kastrup
2008-03-09 0:29 ` Dan Nicolaescu
2008-03-09 10:10 ` David Kastrup
2008-03-09 15:02 ` Dan Nicolaescu
2008-03-09 16:40 ` Richard Stallman
2008-03-09 16:39 ` Richard Stallman
2008-03-09 17:57 ` Juri Linkov
2008-03-10 6:12 ` Richard Stallman
2008-03-11 0:20 ` David Kastrup
2008-03-09 19:07 ` Glenn Morris
2008-03-10 3:02 ` Stefan Monnier
2008-03-10 6:11 ` Richard Stallman
2008-03-10 22:07 ` Glenn Morris
2008-03-11 20:24 ` Richard Stallman
2008-03-09 20:53 ` Diffs between %s and %s end here (was: vc-set-mode-line-busy-indicator) Richard Stallman
2008-03-09 22:39 ` Diffs between %s and %s end here Reiner Steib
2008-03-08 19:18 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-09 16:40 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-09 17:10 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-09 16:40 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-07 3:55 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-03 1:56 ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-03 18:27 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-03 21:04 ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-04 17:37 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-03 23:27 ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-04 17:38 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-04 19:29 ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-04 22:33 ` vc-set-mode-line-busy-indicator Stefan Monnier
2008-03-05 21:33 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-02 5:53 ` vc-set-mode-line-busy-indicator Stefan Monnier
2008-03-02 6:15 ` vc-set-mode-line-busy-indicator Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434pbqcaz5.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).