unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman.073@student.lu.se>
Cc: Juanma Barranquero <lekktu@gmail.com>, emacs-devel@gnu.org
Subject: Re: defadvice in Emacs code (was: Kill ring leak in winemacs macros]
Date: Fri, 05 Aug 2005 15:48:55 +0200	[thread overview]
Message-ID: <42F36E47.4020308@student.lu.se> (raw)
In-Reply-To: <E1E10rU-0005zx-Vf@fencepost.gnu.org>

Richard M. Stallman wrote:

>These are all bugs that ought to be fixed.  In general I did not know
>they used defadvice when the code was installed.
>  
>
I looked at the help text for defadvice and followed the link to Info (a 
very useful link!). In the help text I found nothing about defadvice 
usage in Emacs. The text in Info says "This is a clean method for a 
library to customize functions defined within Emacs--cleaner than 
redefining the whole function". Maybe it should be pointed out somewhere 
that this should not be used within Emacs itself?

Viper also has a lot of defadvice. It might be necessary in the case of 
viper, I do not know.

      parent reply	other threads:[~2005-08-05 13:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-03 19:10 [EPeterson@mcdonaldbradley.com: Kill ring leak in winemacs macros] Richard M. Stallman
2005-08-03 19:27 ` Stuart D. Herring
2005-08-03 19:52   ` Lennart Borgman
2005-08-03 20:59     ` Stuart D. Herring
2005-08-03 21:41       ` Lennart Borgman
2005-08-04  3:55         ` Eli Zaretskii
2005-08-04  7:25           ` Lennart Borgman
2005-08-03 23:12       ` Kevin Rodgers
2005-08-04 15:34         ` Stuart D. Herring
2005-08-16 15:07         ` Stuart D. Herring
2005-08-16 16:10           ` Jason Rumney
2005-08-16 16:19             ` Jason Rumney
2005-08-17  6:24               ` Richard M. Stallman
2005-08-18 16:43               ` Kevin Rodgers
2005-08-18 21:15                 ` Jason Rumney
2005-08-18 22:17                   ` Stuart D. Herring
2005-08-16 16:31             ` Stuart D. Herring
2005-08-16 21:38               ` Jason Rumney
2005-08-18 16:57                 ` Kevin Rodgers
2005-08-18 16:56               ` Kevin Rodgers
2005-08-18 17:52                 ` Stuart D. Herring
2005-08-04 12:48       ` Richard M. Stallman
     [not found]   ` <E1E0f9R-0003Pk-NJ@fencepost.gnu.org>
2005-08-04 14:19     ` Lennart Borgman
2005-08-04 15:20     ` Juanma Barranquero
2005-08-05 11:59       ` Richard M. Stallman
2005-08-05 12:43         ` Juanma Barranquero
2005-08-06  6:27           ` Richard M. Stallman
2005-08-05 13:48         ` Lennart Borgman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42F36E47.4020308@student.lu.se \
    --to=lennart.borgman.073@student.lu.se \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).