From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hunter Newsgroups: gmane.emacs.devel Subject: Re: Code inspection: W32 specific problems Date: Sat, 16 Jul 2005 13:16:54 -0400 Message-ID: <42D94106.6010500@comcast.net> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080002040901010505050209" X-Trace: sea.gmane.org 1121534738 26087 80.91.229.2 (16 Jul 2005 17:25:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 16 Jul 2005 17:25:38 +0000 (UTC) Cc: emacs-devel@gnu.org, "Kim F. Storm" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 16 19:25:29 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DtqOZ-00027J-2O for ged-emacs-devel@m.gmane.org; Sat, 16 Jul 2005 19:24:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DtqQP-0005Dc-42 for ged-emacs-devel@m.gmane.org; Sat, 16 Jul 2005 13:26:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DtqPe-0004uN-SB for emacs-devel@gnu.org; Sat, 16 Jul 2005 13:25:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DtqPS-0004oY-Sn for emacs-devel@gnu.org; Sat, 16 Jul 2005 13:25:12 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DtqPQ-0004me-Hb for emacs-devel@gnu.org; Sat, 16 Jul 2005 13:25:04 -0400 Original-Received: from [204.127.202.59] (helo=sccrmhc14.comcast.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DtqQ5-0000rx-PM; Sat, 16 Jul 2005 13:25:45 -0400 Original-Received: from [192.168.42.3] (pcp08774087pcs.mtlrel01.nj.comcast.net[68.36.32.221]) by comcast.net (sccrmhc14) with ESMTP id <2005071617165401400mfm37e>; Sat, 16 Jul 2005 17:16:55 +0000 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax) X-Accept-Language: en-us, en Original-To: Eli Zaretskii In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:41014 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41014 This is a multi-part message in MIME format. --------------080002040901010505050209 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Eli Zaretskii wrote: > As for Qw32_charset_default and Vx_hand_shape, someone with more > knowledge in the w32 code than myself should look at this. The declaration for Vx_hand_shape may be removed. Qw32_charset_default was declared in w32term.c rev 1.62 in early 2000, but was not defined there either. It is potentially used by several codepaths, notably in enum_font_cb2(). The related symbol 'w32-charset-default' also exists in documentation. It should be defined. Here's a patch. -Dave --------------080002040901010505050209 Content-Type: text/plain; name="w32fns.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="w32fns.c.patch" *** w32fns.c 4 Jul 2005 16:06:36 -0000 1.253 --- w32fns.c 16 Jul 2005 17:13:46 -0000 *************** *** 153,159 **** over text or in the modeline. */ Lisp_Object Vx_pointer_shape, Vx_nontext_pointer_shape, Vx_mode_pointer_shape; ! Lisp_Object Vx_hourglass_pointer_shape, Vx_window_horizontal_drag_shape, Vx_hand_shape; /* The shape when over mouse-sensitive text. */ --- 153,159 ---- over text or in the modeline. */ Lisp_Object Vx_pointer_shape, Vx_nontext_pointer_shape, Vx_mode_pointer_shape; ! Lisp_Object Vx_hourglass_pointer_shape, Vx_window_horizontal_drag_shape; /* The shape when over mouse-sensitive text. */ *************** *** 8760,8765 **** --- 8760,8767 ---- staticpro (&Qw32_charset_ansi); Qw32_charset_ansi = intern ("w32-charset-ansi"); staticpro (&Qw32_charset_symbol); + Qw32_charset_default = intern ("w32-charset-default"); + staticpro (&Qw32_charset_default); Qw32_charset_symbol = intern ("w32-charset-symbol"); staticpro (&Qw32_charset_shiftjis); Qw32_charset_shiftjis = intern ("w32-charset-shiftjis"); --------------080002040901010505050209 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --------------080002040901010505050209--