From: David Hunter <hunterd_42@comcast.net>
Cc: emacs-devel@gnu.org, "Kim F. Storm" <storm@cua.dk>
Subject: Re: Code inspection: W32 specific problems
Date: Sat, 16 Jul 2005 13:16:54 -0400 [thread overview]
Message-ID: <42D94106.6010500@comcast.net> (raw)
In-Reply-To: <ull47kmuz.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
Eli Zaretskii wrote:
> As for Qw32_charset_default and Vx_hand_shape, someone with more
> knowledge in the w32 code than myself should look at this.
The declaration for Vx_hand_shape may be removed.
Qw32_charset_default was declared in w32term.c rev 1.62 in early 2000, but was not defined there either. It is potentially used by several codepaths, notably in enum_font_cb2(). The related symbol 'w32-charset-default' also exists in documentation. It should be defined.
Here's a patch.
-Dave
[-- Attachment #2: w32fns.c.patch --]
[-- Type: text/plain, Size: 1098 bytes --]
*** w32fns.c 4 Jul 2005 16:06:36 -0000 1.253
--- w32fns.c 16 Jul 2005 17:13:46 -0000
***************
*** 153,159 ****
over text or in the modeline. */
Lisp_Object Vx_pointer_shape, Vx_nontext_pointer_shape, Vx_mode_pointer_shape;
! Lisp_Object Vx_hourglass_pointer_shape, Vx_window_horizontal_drag_shape, Vx_hand_shape;
/* The shape when over mouse-sensitive text. */
--- 153,159 ----
over text or in the modeline. */
Lisp_Object Vx_pointer_shape, Vx_nontext_pointer_shape, Vx_mode_pointer_shape;
! Lisp_Object Vx_hourglass_pointer_shape, Vx_window_horizontal_drag_shape;
/* The shape when over mouse-sensitive text. */
***************
*** 8760,8765 ****
--- 8760,8767 ----
staticpro (&Qw32_charset_ansi);
Qw32_charset_ansi = intern ("w32-charset-ansi");
staticpro (&Qw32_charset_symbol);
+ Qw32_charset_default = intern ("w32-charset-default");
+ staticpro (&Qw32_charset_default);
Qw32_charset_symbol = intern ("w32-charset-symbol");
staticpro (&Qw32_charset_shiftjis);
Qw32_charset_shiftjis = intern ("w32-charset-shiftjis");
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2005-07-16 17:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-12 12:44 Code inspection: W32 specific problems Kim F. Storm
2005-07-12 18:59 ` Eli Zaretskii
2005-07-12 22:28 ` Stefan Monnier
2005-07-13 8:10 ` Kim F. Storm
2005-07-16 11:32 ` Eli Zaretskii
2005-07-16 17:16 ` David Hunter [this message]
2005-07-18 12:29 ` Kim F. Storm
2005-07-19 1:02 ` David Hunter
2005-07-19 8:51 ` Kim F. Storm
2005-07-19 3:37 ` Eli Zaretskii
2005-07-19 8:55 ` Kim F. Storm
2005-07-19 17:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42D94106.6010500@comcast.net \
--to=hunterd_42@comcast.net \
--cc=emacs-devel@gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).