From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Davis Herring" Newsgroups: gmane.emacs.devel Subject: Re: Patch: prefer-window-split-horizontally Date: Wed, 15 Aug 2007 08:24:08 -0700 (PDT) Message-ID: <42925.128.165.123.18.1187191448.squirrel@webmail.lanl.gov> References: <87bqdajcr1.fsf@baldur.tsdh.de> <87vebij5p8.fsf@jurta.org> <87eji5wear.fsf@baldur.tsdh.de> Reply-To: herring@lanl.gov NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1187191474 20050 80.91.229.12 (15 Aug 2007 15:24:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 15 Aug 2007 15:24:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Tassilo Horn" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 15 17:24:27 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ILKjR-0007l9-Ef for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2007 17:24:25 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ILKjQ-0003AD-Su for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2007 11:24:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ILKjN-0003A5-Tq for emacs-devel@gnu.org; Wed, 15 Aug 2007 11:24:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ILKjL-00039Q-Cp for emacs-devel@gnu.org; Wed, 15 Aug 2007 11:24:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ILKjL-00039M-3u for emacs-devel@gnu.org; Wed, 15 Aug 2007 11:24:19 -0400 Original-Received: from mailwasher.lanl.gov ([192.65.95.54] helo=mailwasher-b.lanl.gov) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ILKjG-0000eO-7P; Wed, 15 Aug 2007 11:24:14 -0400 Original-Received: from mailrelay2.lanl.gov (mailrelay2.lanl.gov [128.165.4.103]) by mailwasher-b.lanl.gov (8.13.8/8.13.6/(ccn-5)) with ESMTP id l7FFO9Vk000887; Wed, 15 Aug 2007 09:24:10 -0600 Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay2.lanl.gov (8.13.8/8.13.8/(ccn-5)) with ESMTP id l7FFO9L2002465; Wed, 15 Aug 2007 09:24:09 -0600 Original-Received: from webmail1.lanl.gov (localhost.localdomain [127.0.0.1]) by webmail1.lanl.gov (8.12.11.20060308/8.12.11) with ESMTP id l7FFO9rp019106; Wed, 15 Aug 2007 09:24:09 -0600 Original-Received: (from apache@localhost) by webmail1.lanl.gov (8.12.11.20060308/8.12.11/Submit) id l7FFO8F7019103; Wed, 15 Aug 2007 08:24:08 -0700 X-Authentication-Warning: webmail1.lanl.gov: apache set sender to herring@lanl.gov using -f Original-Received: from 128.165.123.18 (SquirrelMail authenticated user 196434) by webmail.lanl.gov with HTTP; Wed, 15 Aug 2007 08:24:08 -0700 (PDT) In-Reply-To: <87eji5wear.fsf@baldur.tsdh.de> User-Agent: SquirrelMail/1.4.8-6.el3.2lanl X-Priority: 3 (Normal) Importance: Normal X-PMX-Version: 4.7.1.128075 X-CTN-5-MailScanner-Information: Please see http://network.lanl.gov/email/virus-scan.php X-CTN-5-MailScanner: Found to be clean X-CTN-5-MailScanner-From: herring@lanl.gov X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76575 Archived-At: > I think your approach would do that. This example function would split > horizontally as long as all windows are 80 or more columns wide. > > --8<---------------cut here---------------start------------->8--- > (defun th-split-window-function () > (save-window-excursion > (save-excursion > (split-window-horizontally) > (balance-windows) > (if (>= (let ((edges (window-edges))) (- (nth 2 edges) (nth 0 > edges))) 80) > 'split-window-horizontally > 'split-window-vertically)))) > --8<---------------cut here---------------end--------------->8--- > > Would you try to implement that? Splitting one window should not involve destroying all Lisp references to existing windows (as `save-window-excursion' must). Unless redisplay would somehow be supressed here (I'm not sure), this would also involve calling `window-size-change-functions' twice for each split, which would be wasteful and perhaps confusing. Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.