From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Re: bug#37656: 27.0.50; Arbitrary code execution with special `mode:' Date: Wed, 16 Oct 2019 13:55:08 +1300 Message-ID: <426c551f6e553d791d7cea986d8933a6@webmail.orcon.net.nz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="220091"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Orcon Webmail Cc: 37656@debbugs.gnu.org, adam plaice , Emacs developers To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 16 02:56:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKXcN-000v9Y-4Q for ged-emacs-devel@m.gmane.org; Wed, 16 Oct 2019 02:56:47 +0200 Original-Received: from localhost ([::1]:34532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKXcM-0004hi-0B for ged-emacs-devel@m.gmane.org; Tue, 15 Oct 2019 20:56:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53577) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKXaz-0004dM-4G for emacs-devel@gnu.org; Tue, 15 Oct 2019 20:55:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKXay-0000jK-4R for emacs-devel@gnu.org; Tue, 15 Oct 2019 20:55:21 -0400 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:56317) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKXax-0000gD-QH for emacs-devel@gnu.org; Tue, 15 Oct 2019 20:55:20 -0400 Original-Received: from [10.253.37.70] (port=37166 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1iKXam-00040V-5N; Wed, 16 Oct 2019 13:55:08 +1300 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Wed, 16 Oct 2019 13:55:08 +1300 In-Reply-To: X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 60.234.4.43 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241077 Archived-At: On 2019-10-16 11:55, Stefan Kangas wrote: > Here is a more complete patch. Does it look like the right fix? I don't think so. If we're removing the multiple 'mode' feature, then `set-auto-mode' says the following about it: ;; Once we drop the deprecated feature where mode: is also allowed to ;; specify minor-modes (ie, there can be more than one "mode:"), we can ;; remove this section and just let (hack-local-variables t) handle it. ;; Find a -*- mode tag.