From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Stuart D. Herring" Newsgroups: gmane.emacs.devel Subject: Re: `key-binding' and XEmacs-style events Date: Tue, 6 Mar 2007 09:06:10 -0800 (PST) Message-ID: <42375.128.165.123.18.1173200770.squirrel@webmail.lanl.gov> References: <36817.128.165.123.18.1172703473.squirrel@webmail.lanl.gov> <38667.128.165.123.18.1172788075.squirrel@webmail.lanl.gov> <85irdk9gnp.fsf@lola.goethe.zz> Reply-To: herring@lanl.gov NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1173201097 18688 80.91.229.12 (6 Mar 2007 17:11:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 6 Mar 2007 17:11:37 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, monnier@iro.umontreal.ca To: "David Kastrup" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 06 18:11:30 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HOdC0-0006IE-1g for ged-emacs-devel@m.gmane.org; Tue, 06 Mar 2007 18:11:19 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HOdBu-0000dm-Ad for ged-emacs-devel@m.gmane.org; Tue, 06 Mar 2007 12:11:10 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HOd9c-0008Ap-Io for emacs-devel@gnu.org; Tue, 06 Mar 2007 12:08:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HOd9X-00088T-TV for emacs-devel@gnu.org; Tue, 06 Mar 2007 12:08:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HOd9X-00088P-N0 for emacs-devel@gnu.org; Tue, 06 Mar 2007 12:08:43 -0500 Original-Received: from mailwasher.lanl.gov ([192.65.95.54] helo=mailwasher-b.lanl.gov) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HOd7Y-00068I-Nx; Tue, 06 Mar 2007 12:06:43 -0500 Original-Received: from mailrelay3.lanl.gov (mailrelay3.lanl.gov [128.165.4.104]) by mailwasher-b.lanl.gov (8.13.8/8.13.8/(ccn-5)) with ESMTP id l26H6B7I025663; Tue, 6 Mar 2007 10:06:11 -0700 Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay3.lanl.gov (8.13.8/8.13.8/(ccn-5)) with ESMTP id l26H6Btl013338; Tue, 6 Mar 2007 10:06:11 -0700 Original-Received: from webmail1.lanl.gov (localhost.localdomain [127.0.0.1]) by webmail1.lanl.gov (8.12.11.20060308/8.12.11) with ESMTP id l26H6Bm8012702; Tue, 6 Mar 2007 10:06:11 -0700 Original-Received: (from apache@localhost) by webmail1.lanl.gov (8.12.11.20060308/8.12.11/Submit) id l26H6AFJ012696; Tue, 6 Mar 2007 09:06:10 -0800 X-Authentication-Warning: webmail1.lanl.gov: apache set sender to herring@lanl.gov using -f Original-Received: from 128.165.123.18 (SquirrelMail authenticated user 196434) by webmail.lanl.gov with HTTP; Tue, 6 Mar 2007 09:06:10 -0800 (PST) In-Reply-To: <85irdk9gnp.fsf@lola.goethe.zz> User-Agent: SquirrelMail/1.4.8-2.el3.7lanl X-Priority: 3 (Normal) Importance: Normal X-PMX-Version: 4.7.1.128075 X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67439 Archived-At: >> We're talking about going the other way -- supporting >> (key-binding [(?a)]) in Emacs (I don't know what XEmacs thinks >> of event-lists with no modifiers). The simplest fix seems to be >> to move the check that the list is at least two long before the >> code that uses its first element as a symbol: >> >> Would someone please install your patch? > > Done, but I am not sure that we have all the documentation in place > that would have made it possible to avoid programming this bug in the > first place. > > And I am utterly unsure that this will cover all cases of some > XEmacs-style sequences possibly being confused with events. Thanks, David! I forgot to include a ChangeLog entry, since I didn't know the patch would just go in as it was; the one you supplied has an off-by-one error, which the following patch fixes. *** ChangeLog.~1.5584.~ 2007-03-06 09:58:24.000000000 -0700 --- ChangeLog 2007-03-06 10:03:57.000000000 -0700 *************** *** 29,35 **** 2007-03-02 Stuart D. Herring ! * keymap.c (Fkey_binding): Don't consider two-element lists as events. 2007-03-01 Kenichi Handa --- 29,35 ---- 2007-03-02 Stuart D. Herring ! * keymap.c (Fkey_binding): Don't consider one-element lists as events. 2007-03-01 Kenichi Handa Thanks again, Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.