From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Ok to set a face on `mode-name' for =?UTF-8?Q?so-long-mode=3F?= Date: Mon, 06 Sep 2021 21:09:52 +1200 Message-ID: <42184fb099811e4d72deee0dd5da5dc9@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7516"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 06 11:11:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNAes-0001nv-LI for ged-emacs-devel@m.gmane-mx.org; Mon, 06 Sep 2021 11:11:18 +0200 Original-Received: from localhost ([::1]:35638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNAer-0006IE-Fn for ged-emacs-devel@m.gmane-mx.org; Mon, 06 Sep 2021 05:11:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNAdc-00056F-Ap for emacs-devel@gnu.org; Mon, 06 Sep 2021 05:10:00 -0400 Original-Received: from smtp-1.orcon.net.nz ([60.234.4.34]:40079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNAdb-0001hh-0R for emacs-devel@gnu.org; Mon, 06 Sep 2021 05:10:00 -0400 Original-Received: from [10.253.37.70] (port=34010 helo=webmail.orcon.net.nz) by smtp-1.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1mNAdV-0001RG-0c for emacs-devel@gnu.org; Mon, 06 Sep 2021 21:09:53 +1200 Original-Received: from ip-116-251-162-85.kinect.net.nz ([116.251.162.85]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Mon, 06 Sep 2021 21:09:52 +1200 X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.34; envelope-from=psainty@orcon.net.nz; helo=smtp-1.orcon.net.nz X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_40=-0.001, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274095 Archived-At: I'd quite like to make the following change to lisp/so-long.el: ;;;###autoload -(define-derived-mode so-long-mode nil "So Long" +(define-derived-mode so-long-mode nil + (propertize "So Long" 'face 'so-long-mode-line-active) "This major mode is the default `so-long-action' option. (`so-long-mode-line-active' simply inherits from `mode-line-emphasis' by default.) It will make the face consistent with that applied to `so-long-mode-line-label' (by `so-long-mode-line-info') when other (non-major-mode) actions are active. In testing the change seems fine. Is there any reason not to do this? I think I'd initially felt that I shouldn't be messing with the face for the something as standard as the major mode name; but on account of having made the `so-long-mode-line-active' face rather high-contrast in my own config, it now seems like a flaw that `mode-name' isn't using that face. I note that the new mode-name for `emacs-lisp-mode' sets a face for the dynamic-binding flag "/d" if that's active, so there's at least one example of something similar. -Phil