From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jackson Ray Hamilton Newsgroups: gmane.emacs.devel Subject: Re: Comprehensive JSX support in Emacs Date: Sun, 7 Apr 2019 16:19:34 -0700 Message-ID: <41a9f273-ef53-d3f2-7feb-769e10c398b5@jacksonrayhamilton.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="260223"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: jackson@jacksonrayhamilton.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 08 01:26:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDHBd-0015ZZ-5T for ged-emacs-devel@m.gmane.org; Mon, 08 Apr 2019 01:26:53 +0200 Original-Received: from localhost ([127.0.0.1]:44845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDHBc-0005ry-47 for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2019 19:26:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDHBT-0005rU-9m for emacs-devel@gnu.org; Sun, 07 Apr 2019 19:26:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDH4c-0000lk-TW for emacs-devel@gnu.org; Sun, 07 Apr 2019 19:19:39 -0400 Original-Received: from mta-10-4.privateemail.com ([198.54.122.62]:63359) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDH4c-0000l7-LH for emacs-devel@gnu.org; Sun, 07 Apr 2019 19:19:38 -0400 Original-Received: from MTA-10.privateemail.com (localhost [127.0.0.1]) by MTA-10.privateemail.com (Postfix) with ESMTP id 052356004A; Sun, 7 Apr 2019 19:19:35 -0400 (EDT) Original-Received: from [192.168.88.227] (unknown [10.20.151.239]) by MTA-10.privateemail.com (Postfix) with ESMTPA id B97EA60049; Sun, 7 Apr 2019 23:19:34 +0000 (UTC) In-Reply-To: Content-Language: en-US X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 198.54.122.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235100 Archived-At: I pushed a few changes (=E2=80=9COptimize js-jsx--matching-close-tag-pos=E2= =80=9D,=20 =E2=80=9COptimize js-jsx--enclosing-tag-pos=E2=80=9D) which made a big di= fference in=20 performance. I was running a function thousands of extra times redundantly. ELP=20 showed that by caching the results, I was able to cut the average=20 waiting time immediately after editing a line by 80%. This made editing=20 some code noticeably more bearable. There might be some better algorithms that can improve the performance=20 even more, but it should be good enough (especially for non-monolithic,=20 well-modularized code) to no longer be a limiting factor for merging it. Jackson