From: "Jan D." <jan.h.d@swipnet.se>
Cc: juri@jurta.org, yamaoka@jpl.org, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: undo in loaddefs.el buffer
Date: Sun, 26 Dec 2004 17:15:52 +0100 [thread overview]
Message-ID: <41CEE3B8.9090600@swipnet.se> (raw)
In-Reply-To: <200412260206.iBQ26wG17970@raven.dms.auburn.edu>
Luc Teirlinck wrote:
>Do `emacs -q', M-x ielm then:
>
>(let (last-nonmenu-event) (yes-or-no-p "prompt"))
>
>Now if you press any key, regular or modifier, say "a", Control,
>Shift, nil is returned, like if you answered "No". This appears to be
>an obvious bug. For the particular application we are worried about,
>this is particularly bad, because "No" is the dangerous answer, the
>one that might make Emacs crash.
>
>
The behaviour to pop down on key press is present in CVS and 21.3. But
this should only happen if the focus is on the frame and not the
dialog. It also only happens for Lucid and Lesstif/Motif dialogs. The
reason for this being in CVS is because it is in 21.3 :-). Personally I
think it is a strange behaviour.
However, I obviously did a typo when making the "pop down on ESC" (see
below), so the Lucid pops down on any keypress when focus is on the
dialog. This is now fixed.
>If we repeat the experiment in 21.3, we see that the bug is not
>present there. However, there is another bug. If we click the mouse
>anywhere inside the Emacs frame, but outside the "Yes" button, nil is
>returned. This is also a bug, which does _not_ occur in current CVS.
>This seems to be a case of introducing one bug by fixing another
>
This way of popping down the dialog has been replaced by popping down by
pressing ESC, which is more in line with what other applications and
toolkits use. But the non-toolkit build uses menus instead of dialogs,
so the behaviour is different. For popup menus, clicking outside means
"cancel" so in that case it is popped down. The ESC thing was not
implemented for the non-toolkit build, I guess I thought it wasn't that
many people that used it and thus not worth it.
So in CVS, dialogs does not pop down because of a click outside the
dialog. The non-toolkit build is not a dialog but a menu, so it does
pop down.
ESC shall pop down dialogs, except for the non-toolkit build (not
implemented, but easy to add).
Any key pressed when the focus is on the Emacs frame and not the dialog
pops down the Lucid and Lesstif/Motif dialog, to be compatible with
21.3. GTK and non-toolkit does not pop down on keypress outside the
dialog/menu.
Jan D.
next prev parent reply other threads:[~2004-12-26 16:15 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-21 14:14 undo in loaddefs.el buffer Luc Teirlinck
2004-12-21 15:41 ` Luc Teirlinck
2004-12-22 4:31 ` Katsumi Yamaoka
2004-12-22 4:58 ` Katsumi Yamaoka
2004-12-23 0:01 ` Richard Stallman
2004-12-23 0:26 ` David Kastrup
2004-12-25 15:13 ` Richard Stallman
2004-12-24 1:45 ` Juri Linkov
2004-12-24 21:39 ` Luc Teirlinck
2004-12-26 9:14 ` Richard Stallman
2004-12-27 5:29 ` Luc Teirlinck
2004-12-27 22:35 ` Richard Stallman
2004-12-24 23:59 ` Luc Teirlinck
2004-12-25 15:12 ` Richard Stallman
2004-12-26 2:06 ` Luc Teirlinck
2004-12-26 2:32 ` Juri Linkov
2004-12-26 3:59 ` Luc Teirlinck
2004-12-27 2:40 ` Luc Teirlinck
2004-12-27 20:16 ` Juri Linkov
2004-12-28 4:57 ` Richard Stallman
2004-12-27 4:09 ` Richard Stallman
2004-12-26 16:15 ` Jan D. [this message]
2004-12-27 2:31 ` Luc Teirlinck
2004-12-27 10:21 ` Jan D.
2004-12-27 11:05 ` Jan D.
2004-12-27 22:35 ` Richard Stallman
2004-12-28 13:16 ` Jan D.
2004-12-28 20:57 ` Richard Stallman
2004-12-29 12:59 ` Jan D.
2004-12-28 5:03 ` Luc Teirlinck
2004-12-28 17:25 ` Richard Stallman
2004-12-29 2:07 ` Luc Teirlinck
2004-12-29 20:46 ` Richard Stallman
2004-12-30 1:14 ` Luc Teirlinck
2004-12-30 16:43 ` Richard Stallman
2004-12-31 1:54 ` Luc Teirlinck
2004-12-31 9:22 ` David Kastrup
2004-12-31 15:04 ` Luc Teirlinck
2005-01-01 5:25 ` Richard Stallman
2005-01-02 16:02 ` Luc Teirlinck
2005-01-03 0:58 ` Richard Stallman
2005-01-04 3:07 ` Luc Teirlinck
2005-01-04 17:00 ` Richard Stallman
2004-12-31 2:14 ` Luc Teirlinck
2004-12-30 5:06 ` Luc Teirlinck
2004-12-30 20:58 ` Richard Stallman
2004-12-27 18:05 ` Richard Stallman
2004-12-27 19:33 ` Jan D.
2004-12-28 4:57 ` Richard Stallman
2004-12-28 8:11 ` Jan D.
2004-12-28 21:05 ` Jason Rumney
2004-12-29 23:22 ` Jan D.
2004-12-27 4:09 ` Richard Stallman
2004-12-27 4:42 ` Luc Teirlinck
2004-12-26 2:43 ` Juri Linkov
2004-12-27 4:09 ` Richard Stallman
2005-01-04 9:05 ` Juri Linkov
2004-12-21 21:57 ` Kevin Rodgers
2004-12-22 0:17 ` Luc Teirlinck
2004-12-22 0:17 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41CEE3B8.9090600@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
--cc=rms@gnu.org \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).