unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Ponce <david.ponce@wanadoo.fr>
Cc: emacs-devel@gnu.org
Subject: Re: New easymenu behavior
Date: Wed, 03 Nov 2004 14:04:22 +0000	[thread overview]
Message-ID: <4188E566.5080601@wanadoo.fr> (raw)
In-Reply-To: <x57jp3jfk7.fsf@lola.goethe.zz>

 > What does your code do that did not already break in Emacs 21.3?

recentf simply uses (easy-menu-add-item nil '("files") ...) to add the
recentf menu into the "File" menu which is identified with the 'files
key symbol. This worked well in 21.3 because the code just interned
"files" to get the key symbol.

 > The new behavior is certainly no bug: it is entirely easymenu's
 > choice what symbols to use for some menu, that's some internal
 > decision.  I can't rule out, however, that maybe easy-menu-intern is
 > used in more or less places than required, which could cause such
 > mismatches.
 >
 > Can you go into details about the usage patterns that cause this
 > problem?  If they do not have similar problems with Emacs-21.3
 > already, there might be some bug.

In 21.4, before the last change to easy-menu-intern, that worked too
because the code interned the downcased strings in the menu path.

Now it fails because "files" returns the symbol 'Files as the key to
locate the menu item.

IMHO, the 21.3 version looks better because it doesn't change the
meaning of strings given to locate a menu item.  So it should be able
to locate "Greek" as a different menu item from "greek".

 >>What about compatibility with existing code that uses easymenu?
 >
 >
 > It should not be tampering with internals.  If your problem is not
 > due to that, you should provide examples of what happens.
 >

Notice that XEmacs directly use menu item names to locate them.  For
example you can use '("File") to locate the "File" menu in the menu
bar. Maybe is it a better mechanism to use in external libraries?

Thanks
David

  reply	other threads:[~2004-11-03 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-03 11:36 New easymenu behavior David Ponce
2004-11-03 12:13 ` David Kastrup
2004-11-03 14:04   ` David Ponce [this message]
2004-11-03 13:56     ` David Kastrup
2004-11-03 15:28       ` David Ponce
2004-11-03 14:27         ` David Kastrup
2004-11-03 15:37           ` David Ponce
2004-11-04  9:52         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4188E566.5080601@wanadoo.fr \
    --to=david.ponce@wanadoo.fr \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).