* did compilation-mode loose an arg?
@ 2004-09-04 23:34 Kevin A. Burton
2004-09-05 17:25 ` Richard Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Kevin A. Burton @ 2004-09-04 23:34 UTC (permalink / raw)
I noticed that the JDE assumes that compilation-mode accepts an arg (and
my builds were failing). Probably the name of the buffer name to use.
I just redefined it as:
(defun compilation-mode (&optional foo)
and it worked...
FYI.
Kevin
--
Please reply using PGP.
http://peerfear.org/pubkey.asc
NewsMonster - http://www.newsmonster.org/
Kevin A. Burton, Location - San Francisco, CA, Cell - 415.595.9965
AIM/YIM - sfburtonator, Web - http://peerfear.org/
GPG fingerprint: 5FB2 F3E2 760E 70A8 6174 D393 E84D 8D04 99F1 4412
IRC - freenode.net #infoanarchy | #p2p-hackers | #newsmonster
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: did compilation-mode loose an arg?
2004-09-04 23:34 did compilation-mode loose an arg? Kevin A. Burton
@ 2004-09-05 17:25 ` Richard Stallman
2004-09-05 19:48 ` Kevin A. Burton
0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2004-09-05 17:25 UTC (permalink / raw)
Cc: emacs-devel
THis change should bring back the lost feature. Is it ok?
Index: compile.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/progmodes/compile.el,v
retrieving revision 1.327
diff -c -c -r1.327 compile.el
*** compile.el 4 Sep 2004 12:47:21 -0000 1.327
--- compile.el 5 Sep 2004 17:10:54 -0000
***************
***************
*** 1103,1109 ****
:version "21.4")
;;;###autoload
! (defun compilation-mode ()
"Major mode for compilation log buffers.
\\<compilation-mode-map>To visit the source for a line-numbered error,
move point to the error message line and type \\[compile-goto-error].
--- 1103,1109 ----
:version "21.4")
;;;###autoload
! (defun compilation-mode (&optional name-of-mode)
"Major mode for compilation log buffers.
\\<compilation-mode-map>To visit the source for a line-numbered error,
move point to the error message line and type \\[compile-goto-error].
***************
*** 1116,1122 ****
(kill-all-local-variables)
(use-local-map compilation-mode-map)
(setq major-mode 'compilation-mode
! mode-name "Compilation")
(set (make-local-variable 'page-delimiter)
compilation-page-delimiter)
(compilation-setup)
--- 1116,1122 ----
(kill-all-local-variables)
(use-local-map compilation-mode-map)
(setq major-mode 'compilation-mode
! mode-name (or name-of-mode "Compilation"))
(set (make-local-variable 'page-delimiter)
compilation-page-delimiter)
(compilation-setup)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-05 19:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-04 23:34 did compilation-mode loose an arg? Kevin A. Burton
2004-09-05 17:25 ` Richard Stallman
2004-09-05 19:48 ` Kevin A. Burton
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).