From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Stuart D. Herring" Newsgroups: gmane.emacs.devel Subject: Re: Problem report #15 Date: Wed, 12 Apr 2006 10:36:51 -0700 (PDT) Message-ID: <41129.128.165.123.132.1144863411.squirrel@webmail.lanl.gov> References: <200604111548.k3BFmH6g015084@scanner2.ics.uci.edu> <39862.128.165.123.132.1144777442.squirrel@webmail.lanl.gov> Reply-To: herring@lanl.gov NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1144863463 17516 80.91.229.2 (12 Apr 2006 17:37:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 12 Apr 2006 17:37:43 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 12 19:37:34 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FTjHF-0008Rz-Uf for ged-emacs-devel@m.gmane.org; Wed, 12 Apr 2006 19:37:18 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FTjHF-0007Vw-Bs for ged-emacs-devel@m.gmane.org; Wed, 12 Apr 2006 13:37:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FTjGz-0007Sz-SX for emacs-devel@gnu.org; Wed, 12 Apr 2006 13:36:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FTjGy-0007RP-Ed for emacs-devel@gnu.org; Wed, 12 Apr 2006 13:36:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FTjGy-0007RM-5X for emacs-devel@gnu.org; Wed, 12 Apr 2006 13:36:56 -0400 Original-Received: from [192.65.95.54] (helo=mailwasher-b.lanl.gov) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FTjM5-0006Yh-L7; Wed, 12 Apr 2006 13:42:13 -0400 Original-Received: from mailrelay3.lanl.gov (mailrelay3.lanl.gov [128.165.4.104]) by mailwasher-b.lanl.gov (8.12.11/8.12.11/(ccn-5)) with ESMTP id k3CHar4H024387; Wed, 12 Apr 2006 11:36:53 -0600 Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay3.lanl.gov (8.12.11.20060308/8.12.11/(ccn-5)) with ESMTP id k3CHaq3l013299; Wed, 12 Apr 2006 11:36:52 -0600 Original-Received: from webmail1.lanl.gov (localhost.localdomain [127.0.0.1]) by webmail1.lanl.gov (8.12.11.20060308/8.12.11) with ESMTP id k3CHaqSI004187; Wed, 12 Apr 2006 11:36:52 -0600 Original-Received: (from apache@localhost) by webmail1.lanl.gov (8.12.11.20060308/8.12.11/Submit) id k3CHapQh004185; Wed, 12 Apr 2006 10:36:52 -0700 X-Authentication-Warning: webmail1.lanl.gov: apache set sender to herring@lanl.gov using -f Original-Received: from 128.165.123.132 (SquirrelMail authenticated user 196434); by webmail.lanl.gov with HTTP; Wed, 12 Apr 2006 10:36:51 -0700 (PDT) In-Reply-To: Original-To: rms@gnu.org User-Agent: SquirrelMail/1.4.3a-11.EL3 X-Mailer: SquirrelMail/1.4.3a-11.EL3 X-Priority: 3 (Normal) Importance: Normal X-PMX-Version: 4.7.1.128075 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52790 Archived-At: > FAMILY can't be invalid because get_lisp_to_sockaddr_size > has made sure it is valid. > > (The comment said size_lisp_to_sockaddr; I fixed that.) I don't see how get_lisp_to_sockaddr_size does that. If `address' is a Lisp vector but has length, say, 15, it seems that `family' (`familyp') is never assigned. As far as I can tell, no one ever checks the value of family between there and where it is compared to AF_INET and AF_INET6. If it compares unequal to each of those, then `cp' in conv_lisp_to_sockaddr will be left NULL and the last line in conv_lisp_to_sockaddr will segfault. I think this bug is real, then -- probably just need to signal a Lisp error in conv_lisp_to_sockaddr if the address is a vector but family is neither AF_INET nor AF_INET6. Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.