From: Lars Hansen <larsh@math.ku.dk>
Cc: emacs-devel@gnu.org
Subject: Re: desktop.el and minor modes
Date: Mon, 31 May 2004 12:20:49 +0200 [thread overview]
Message-ID: <40BB0701.9020807@math.ku.dk> (raw)
In-Reply-To: <87aczpn09z.fsf@mail.jurta.org>
Juri Linkov wrote:
>desktop.el saves variable names to the minor-modes slot of
>`desktop-create-buffer', but those variables can't be funcalled
>when desktop is restored.
>
The conventions for minor modes is that the same symbol should be used
for the mode variable as for the enabling function.
Those minor modes having a different name for the toggling function,
should have be listed in desktop-minor-modes-table.
>Perhaps `desktop-save' should check if a symbol from
>`minor-mode-alist' is a function in case if there is no corresponding
>variable-to-function mapping in `desktop-minor-mode-table'?
>
When desktop restores a buffer, it checks if there is a function
definition for each symbol in desktop-buffer-minor-modes before calling it.
I don't see why doing this check at desktop-save should be better.
The problem with dired-omit-files-p is that it does not follow the
conventions.
Rather than hacking desktop to work around this, I think dired-x should
be changed.
The result is much cleaner.
I suggest something like:
1. Rename variable dired-omit-files-p to dired-omit-mode
2. Replace function dired-omit-toggle with functions
- dired-omit-mode following the convention for the argument
- dired-mark-omit marking files to omit
next prev parent reply other threads:[~2004-05-31 10:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-30 20:11 desktop.el and minor modes Juri Linkov
2004-05-31 10:20 ` Lars Hansen [this message]
2004-05-31 13:16 ` Lars Hansen
2004-05-31 13:52 ` Juri Linkov
2004-05-31 16:38 ` Lars Hansen
2004-05-31 19:26 ` Miles Bader
2004-05-31 21:22 ` Lars Hansen
2004-05-31 13:52 ` Juri Linkov
2004-05-31 21:48 ` Lars Hansen
[not found] ` <87vfici4md.fsf@mail.jurta.org>
2004-06-01 6:22 ` Lars Hansen
2004-06-01 16:34 ` Juri Linkov
2004-06-02 5:50 ` Lars Hansen
2004-06-05 1:05 ` Juri Linkov
2004-06-05 16:24 ` {Spam?} " Stefan
2004-06-05 18:02 ` Lars Hansen
2004-06-07 2:07 ` Miles Bader
-- strict thread matches above, loose matches on Subject: below --
2004-06-05 17:59 Lars Hansen
2004-06-05 18:03 ` David Kastrup
2004-06-05 18:14 ` Lars Hansen
2004-06-05 18:47 ` Juri Linkov
2004-06-07 8:09 ` Juri Linkov
2004-06-08 6:49 ` Lars Hansen
2004-06-08 8:02 ` Juri Linkov
2004-06-08 16:10 ` Lars Hansen
2004-06-08 18:43 ` Juri Linkov
2004-06-08 19:24 ` Lars Hansen
2004-06-08 20:11 ` Juri Linkov
2004-06-08 20:22 ` Lars Hansen
2004-06-08 20:32 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40BB0701.9020807@math.ku.dk \
--to=larsh@math.ku.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).