From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: new *Help* argument highlighting Date: Tue, 11 May 2004 10:51:47 -0600 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <40A104A3.4020607@yahoo.com> References: <20040509222555.GA17587@fencepost> <20040510223059.AE6F.LEKTU@mi.madritel.es> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1084294591 11998 80.91.224.253 (11 May 2004 16:56:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 May 2004 16:56:31 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue May 11 18:56:06 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNaY1-0006yt-00 for ; Tue, 11 May 2004 18:56:05 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNaY1-0000TB-00 for ; Tue, 11 May 2004 18:56:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNaXA-0000c3-LO for emacs-devel@quimby.gnus.org; Tue, 11 May 2004 12:55:12 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BNaV1-0007cP-4Q for emacs-devel@gnu.org; Tue, 11 May 2004 12:52:59 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BNaUF-0006rL-7j for emacs-devel@gnu.org; Tue, 11 May 2004 12:52:43 -0400 Original-Received: from [80.91.224.249] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNaTq-0006SU-Qd for emacs-devel@gnu.org; Tue, 11 May 2004 12:51:47 -0400 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1BNaTq-0007RL-00 for ; Tue, 11 May 2004 18:51:46 +0200 Original-Received: from 170.207.51.80 ([170.207.51.80]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 May 2004 18:51:46 +0200 Original-Received: from ihs_4664 by 170.207.51.80 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 May 2004 18:51:46 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 24 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 170.207.51.80 User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:0.9.4.1) Gecko/20020406 Netscape6/6.2.2 X-Accept-Language: en-us X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23157 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23157 Juanma Barranquero wrote: > On Mon, 10 May 2004 13:54:11 -0400, Richard Stallman wrote: >>Yes, it would be good to downcase them in the Help buffer as well as >>italicizing them. > > That's a one-line patch, and the effect is nice, and scarcely intrusive. > However, it has the problem that if someone customizes > help-argument-face to the default face, he's lost also the uppercase, so > now arguments do not stand out at all. > > To solve that, we'd have do something like: > > (defvar help-arg-highlighting-function > #'(lambda (arg) (propertize (downcase arg) 'face '(:slant italic))) > "Function to call to highlight argument names in `describe-function' *Help* buffers.") > > instead of having a help-argument-name face. No, you just need to check (face-differs-from-default-p 'help-argument-name) before downcasing the argument. -- Kevin Rodgers