From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: [patch] add interactive browse of revisions from vc *Annotate* buffers Date: Thu, 22 Jan 2004 16:20:13 -0700 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <40105AAD.9070008@yahoo.com> References: <1073937837.2822.180.camel@localhost> <1074519239.10692.24.camel@localhost> <1074621500.13077.151.camel@localhost> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1074813769 8091 80.91.224.253 (22 Jan 2004 23:22:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 22 Jan 2004 23:22:49 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jan 23 00:22:45 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ajo9t-00069I-00 for ; Fri, 23 Jan 2004 00:22:45 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ajo9s-0005YV-00 for ; Fri, 23 Jan 2004 00:22:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Ajo9E-00057Z-Md for emacs-devel@quimby.gnus.org; Thu, 22 Jan 2004 18:22:04 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1Ajo7u-0004k9-HH for emacs-devel@gnu.org; Thu, 22 Jan 2004 18:20:42 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Ajo7N-0004RU-A7 for emacs-devel@gnu.org; Thu, 22 Jan 2004 18:20:40 -0500 Original-Received: from [80.91.224.249] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Ajo7L-0004QQ-Uo for emacs-devel@gnu.org; Thu, 22 Jan 2004 18:20:08 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1Ajo7K-00006b-00 for ; Fri, 23 Jan 2004 00:20:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Received: from sea.gmane.org ([80.91.224.252]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ajo7H-00006T-00 for ; Fri, 23 Jan 2004 00:20:03 +0100 Original-Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian)) id 1Ajo7H-00020R-00 for ; Fri, 23 Jan 2004 00:20:03 +0100 Original-Lines: 16 Original-X-Complaints-To: usenet@sea.gmane.org User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:0.9.4.1) Gecko/20020406 Netscape6/6.2.2 X-Accept-Language: en-us X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19443 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19443 Benjamin Rutt wrote: > Stefan Monnier writes: >>I strongly expect that the problem is in the fact that you use view-mode as >>parent even though it's not a major-mode. > > Thanks for the tip, you are correct; I guess define-derived-mode was > somewhat misleading to me since it doesn't mention anywhere in 'C-h f > define-derived-mode' that it only works for major modes. It would be nice if there was a major-mode-p predicate that define-derived-mode could use to verify its PARENT argument. -- Kevin Rodgers