From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Proposal for an improved `help-for-help' Date: Wed, 07 Apr 2021 19:50:42 +0000 Message-ID: <3ec7e2e58ad49cc5aa89@heytings.org> References: <838s7hxqkr.fsf@gnu.org> <3ec7e2e58a0cce3eda09@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38028"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 21:53:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUEF5-0009k1-HE for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 21:53:35 +0200 Original-Received: from localhost ([::1]:60140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUEF4-0002wA-JN for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 15:53:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUECN-00007P-6t for emacs-devel@gnu.org; Wed, 07 Apr 2021 15:50:47 -0400 Original-Received: from heytings.org ([95.142.160.155]:32946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUECL-0002Jn-1t for emacs-devel@gnu.org; Wed, 07 Apr 2021 15:50:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617825043; bh=imm6ud0BoXMX6mCIT0Ad1hN+zLcTrOLISrmqRXNS/40=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=tCq2SfVJyktZh+89SqmzACKDJbP6crMMjDIRvn1QO2pdltxXrDFcqkX3ucVpDN449 TcvjaXYFVAgjAqmI3lZfQkRqbgJCzsyJhPvqx40GJ9aAjazAmighCi70hEWQJrjTqZ IXpCoxumog/zGZP7JKGzAWQFWjcGbIugmjFX+v7ozIumN5dCsjqerbwtzdlwA/qosX XqmuS0jQ7DZAkHqhLPmUMWzzjhvZRlCrp22YZz8aw2P5IboPFXVTny3c2KYiGqysdN +HyIi2lRVN+2bnl5IdbPvNgPrYlw+hTJnqoxES9ki7UwDvZiX2c80wILnwRjKazTlR +Dmh6bNiGo5zg== In-Reply-To: <3ec7e2e58a0cce3eda09@heytings.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267568 Archived-At: >> There have been no further comments here within 4 weeks. >> >> I intend to finish this up and push this to master in the next couple >> of days. Please send any further comments soon, or we will have to >> consider them after this lands on master. Thanks in advance. > > A few comments: > > Your patch breaks search-forward-help-for-help, in which the " > *Metahelp*" buffer name is hardcoded. > > I would add "C-s to search, " after "to scroll,". > > I find the last section name "Language Help" unclear. > > I would add "(see also M-x list-packages)" after "External packages". > > Why did you put a blank line between where-is and apropos-command? > Another small comment: your patch adds two warnings to the build process: In help--for-help-make-commands: help.el:206:27: Warning: Unused lexical variable `arg' In help--for-help-make-sections: help.el:225:13: Warning: Unused lexical variable `title'