From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Wed, 07 Apr 2021 10:22:26 +0000 Message-ID: <3ec7e2e58ab39455c2c6@heytings.org> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <2599ffef-4f70-025c-5f9c-61b9ac94faf8@inventati.org> <87czv7z48f.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="nxrPcUrVye" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12708"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Manuel Uberti , emacs-devel@gnu.org, Stefan Monnier , Zhiwei Chen , =?UTF-8?Q?Daniel_Mart=C3=ADn?= To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 12:30:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lU5Rl-00037i-DJ for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 12:30:05 +0200 Original-Received: from localhost ([::1]:38890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU5Rk-0000Vw-ES for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 06:30:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU5KS-0002CU-RB for emacs-devel@gnu.org; Wed, 07 Apr 2021 06:22:32 -0400 Original-Received: from heytings.org ([95.142.160.155]:60456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU5KQ-0003eM-N3 for emacs-devel@gnu.org; Wed, 07 Apr 2021 06:22:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617790946; bh=Dk2mD61Wd2cbECQhMaEvoj7A18tDx4HZP705Fwq2Mwc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=SaB+Br4mrVP+xV7I4lkQbWS022hmyOvr3KsH6wOA/5t3QyZAYm/lUdZDN+XI1ZhCo gaHSs3pcQLW9wpnNoWcF4VjpVoz3zkmWh7Q+xGFDd8EAmPms5/fW2tTICyRToCIjw7 zuTbEnVTyZYN2SwejityWSO0+mpWwvNOvWPdncqxdSViKUmBhbeuwgQ+1RhcxmG08N ToCHIAYBzA2Rdxs0R217i9aRMezfwYlqIYqgbMgfv6CDS0pCuKaCDuJVVuj263JfS1 2E5dkBhML0PMfudprCpSbfWsNVDCplqxou4Hot16411hzg0LSepIIj7r9QiXb5ss2T SPVUTt1aTDNlw== In-Reply-To: Content-ID: <3ec7e2e58af2cc7156f5@heytings.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267502 Archived-At: --nxrPcUrVye Content-Type: text/plain; charset=us-ascii; format=flowed Content-ID: <3ec7e2e58aa77cc63fcc@heytings.org> >>> And here is a micro-patch to fix that behavior. >>> >>> + ;; Terminate the search if point has moved to another buffer. >>> + (unless (eq isearch-buffer (current-buffer)) >>> + (isearch-cancel)) >> >> Have you tested this with 'multi-isearch-buffers'? > > No, because I did not know that multi-isearch-buffers exists. I see > that it uses multi-isearch-current-buffer in a similar way than > isearch-buffer, but currently I don't know anything else about > multi-isearch-buffers, so I cannot try to fix this. > Okay, I looked a bit closer at multi-isearch, and it seems that the attached patch works with mutli-isearch, too. --nxrPcUrVye Content-Type: text/x-diff; name=0001-Terminate-isearch-when-point-has-moved-to-another-bu.patch; charset=us-ascii Content-Transfer-Encoding: base64 Content-ID: <3ec7e2e58a3285c60f48@heytings.org> Content-Description: Content-Disposition: attachment; filename=0001-Terminate-isearch-when-point-has-moved-to-another-bu.patch RnJvbSAyYTAwMGQyZWVlMjVjYTBjY2JiNWYwYzYzOGM3YzliZDBhNjUzODA4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBXZWQsIDcgQXBy IDIwMjEgMTA6MTY6MjQgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gVGVybWlu YXRlIGlzZWFyY2ggd2hlbiBwb2ludCBoYXMgbW92ZWQgdG8gYW5vdGhlciBi dWZmZXINCg0KKiBsaXNwL2lzZWFyY2guZWwgKGlzZWFyY2gtcG9zdC1jb21t YW5kLWhvb2spOiBUZXJtaW5hdGUgaXNlYXJjaA0Kd2hlbiB0aGUgY29tbWFu ZCBqdXN0IGV4ZWN1dGVkIGhhcyBtb3ZlZCBwb2ludCB0byBhbm90aGVyIGJ1 ZmZlci4NCi0tLQ0KIGxpc3AvaXNlYXJjaC5lbCB8IDMgKysrDQogMSBmaWxl IGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQ0KDQpkaWZmIC0tZ2l0IGEvbGlz cC9pc2VhcmNoLmVsIGIvbGlzcC9pc2VhcmNoLmVsDQppbmRleCBhODI4YzU2 OWFhLi5hOTNlN2E5NTc2IDEwMDY0NA0KLS0tIGEvbGlzcC9pc2VhcmNoLmVs DQorKysgYi9saXNwL2lzZWFyY2guZWwNCkBAIC0zMDQwLDYgKzMwNDAsOSBA QCBTZWUgbW9yZSBmb3Igb3B0aW9ucyBpbiBgc2VhcmNoLWV4aXQtb3B0aW9u Jy4iDQogICAgICAgICAgICAoZ290by1jaGFyIGlzZWFyY2gtcHJlLW1vdmUt cG9pbnQpKQ0KICAgICAgICAgIChpc2VhcmNoLXNlYXJjaC1hbmQtdXBkYXRl KSkpDQogICAgICAoc2V0cSBpc2VhcmNoLXByZS1tb3ZlLXBvaW50IG5pbCkp DQorICA7OyBUZXJtaW5hdGUgdGhlIHNlYXJjaCBpZiBwb2ludCBoYXMgbW92 ZWQgdG8gYW5vdGhlciBidWZmZXIuDQorICAodW5sZXNzIChlcSBpc2VhcmNo LS1jdXJyZW50LWJ1ZmZlciAoY3VycmVudC1idWZmZXIpKQ0KKyAgICAod2l0 aC1jdXJyZW50LWJ1ZmZlciBpc2VhcmNoLS1jdXJyZW50LWJ1ZmZlciAoaXNl YXJjaC1leGl0KSkpDQogICAoZm9yY2UtbW9kZS1saW5lLXVwZGF0ZSkpDQog DQogKGRlZnVuIGlzZWFyY2gtcXVvdGUtY2hhciAoJm9wdGlvbmFsIGNvdW50 KQ0KLS0gDQoyLjMwLjINCg0K --nxrPcUrVye--