From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Wed, 07 Apr 2021 21:09:15 +0000 Message-ID: <3ec7e2e58a49d4f0ec99@heytings.org> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <878s5wmsjp.fsf@mail.linkov.net> <87mtubz4ls.fsf@mail.linkov.net> <8735w22s9b.fsf@mail.linkov.net> <3ec7e2e58a3733a48ae9@heytings.org> <878s5tc0rn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ergus , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 23:09:55 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUFQw-0007Gl-CL for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 23:09:54 +0200 Original-Received: from localhost ([::1]:39796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUFQv-0003We-C0 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 17:09:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUFQO-00035s-RJ for emacs-devel@gnu.org; Wed, 07 Apr 2021 17:09:20 -0400 Original-Received: from heytings.org ([95.142.160.155]:33056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUFQM-0007VW-Mo for emacs-devel@gnu.org; Wed, 07 Apr 2021 17:09:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617829756; bh=Bcn+yQMOAWrAbFgzMWRrnLrDs/d5sHndO+HpyEM2zrc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=aJEZpD8cMOw1fPvIDSSmr8PLvODR5KVc0jCvULwblyddSnFGz5HUdb5E5h+UU/i7e Ig3D2vhy7vq5pchLLfMzVb+oKYy6war1THtEqab/KI8ZtQkQccPAUmYRBbbQ6IlRMr LeMVgittmrtPtwVvaI0TVarP8Y+mJytwC1WgeoJudtna/dgjMKqa3aLiWkdI17OJ9Y OZpcUx/KBLb80SIoWiEbWW/ccQnRn4luwWExlIlIe4bIuOzFIuXnoBQmp1Qjr3Vp9p T0SCCVt/urGwRGcMS31ZKFLHeCYHg9vcYZg91zETiGeZwAbhCWyfciCCjckrLn39Kb gnheoIW+Aeg0A== In-Reply-To: <878s5tc0rn.fsf@mail.linkov.net> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267576 Archived-At: Thanks for your detailed comments! I think I see what you mean, but I see a problem in your proposed solution: > > And instead of > > (setq this-command (get this-command 'isearch-match-scroll)) > > isearch-pre-command-hook could contain the same code > that is currently duplicated in several commands: > > (setq isearch-just-started t) > (goto-char (window-end)) ;; only this line needs to be > ;; replaced with (funcall jumpform) > (isearch-repeat 'forward) > I'm not sure this would work, because it's not always (isearch-repeat 'forward). For example with M-v it would be 'backward, regardless of the current direction of the search. So I guess it means that another symbol property would be necessary. With C-p it's not clear (to me) if it should depend on the current direction of the search or not. Should C-s C-p change the direction to a backward search, or move to previous line and restart a forward search?