From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Wed, 07 Apr 2021 17:03:03 +0000 Message-ID: <3ec7e2e58a3ce4d2b397@heytings.org> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <2599ffef-4f70-025c-5f9c-61b9ac94faf8@inventati.org> <87czv7z48f.fsf@mail.linkov.net> <3ec7e2e58ab39455c2c6@heytings.org> <87zgya2t7k.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="xT4ooAFDI3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15143"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Manuel Uberti , emacs-devel@gnu.org, Stefan Monnier , Zhiwei Chen , =?UTF-8?Q?Daniel_Mart=C3=ADn?= To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 19:04:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUBaz-0003ol-9F for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 19:04:01 +0200 Original-Received: from localhost ([::1]:40490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUBay-0002SK-8H for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 13:04:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUBa7-00022j-MG for emacs-devel@gnu.org; Wed, 07 Apr 2021 13:03:07 -0400 Original-Received: from heytings.org ([95.142.160.155]:60932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUBa5-0001hx-Lr for emacs-devel@gnu.org; Wed, 07 Apr 2021 13:03:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617814983; bh=VLheDK7yBYFmy2W3TyuEcCOLz3jnOg59RLNvcLLj2DY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=FR15bcUUi1YPQmcyWHfS5BzhRjugWuvN2hq3wLR/HY0S8euKX4Nk4701oKj7eUeZn 9UG2ww5t4YpMBKduCub7xOo+JK4A8fSzzkoPiLAy4nI9GeRgID1G4R1kXAgIbK30Rl fXmRVlYE7y48Z7gUjuxbIF7DkawkNtHpdZA+y00qA5DfNSUoL2R3hrJ2cfqPBShEsI z2D2rs5b6StXOCnBlDl/UmzvtWOCYGnZQC0cAbyd+OsqpP5ApBxc617B24PNLydD3e 1hipBQsjsiGNAIkro9ULL7CQFbLqRast8PUA2a9yYiRZSLkuFSQqxs7dMfoNtkdXES StlWKlxCb1SWg== In-Reply-To: <87zgya2t7k.fsf@mail.linkov.net> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267542 Archived-At: --xT4ooAFDI3 Content-Type: text/plain; charset=us-ascii; format=flowed > > When in your original test case '(pop-to-buffer "*Occur*")' is replaced > with '(kill-current-buffer)': > > (define-key isearch-mode-map (kbd "M-s o") > #'(lambda () > (interactive) > (call-interactively 'isearch-occur) > (kill-current-buffer))) > > then it fails with: > > Error in post-command-hook (isearch-post-command-hook): (error "Selecting deleted buffer") > > All other uses of 'isearch--current-buffer' have a check for a live > buffer, e.g. > > (unless (eq (current-buffer) isearch--current-buffer) > (when (buffer-live-p isearch--current-buffer) > (with-current-buffer isearch--current-buffer > Indeed, updated patch attached. --xT4ooAFDI3 Content-Type: text/x-diff; name=0001-Terminate-isearch-when-point-has-moved-to-another-bu.patch Content-Transfer-Encoding: base64 Content-ID: <3ec7e2e58a1c91eaa92c@heytings.org> Content-Description: Content-Disposition: attachment; filename=0001-Terminate-isearch-when-point-has-moved-to-another-bu.patch RnJvbSBiZmZiZGUzYWQwNWU2NzdjYTQ1YWY1YzBmN2QxOGMxMDE4MWMwNjFm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBXZWQsIDcgQXBy IDIwMjEgMTY6NTg6NTEgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gVGVybWlu YXRlIGlzZWFyY2ggd2hlbiBwb2ludCBoYXMgbW92ZWQgdG8gYW5vdGhlciBi dWZmZXINCg0KKiBsaXNwL2lzZWFyY2guZWwgKGlzZWFyY2gtcG9zdC1jb21t YW5kLWhvb2spOiBUZXJtaW5hdGUgaXNlYXJjaA0Kd2hlbiB0aGUgY29tbWFu ZCBqdXN0IGV4ZWN1dGVkIGhhcyBtb3ZlZCBwb2ludCB0byBhbm90aGVyIGJ1 ZmZlci4NCi0tLQ0KIGxpc3AvaXNlYXJjaC5lbCB8IDQgKysrKw0KIDEgZmls ZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykNCg0KZGlmZiAtLWdpdCBhL2xp c3AvaXNlYXJjaC5lbCBiL2xpc3AvaXNlYXJjaC5lbA0KaW5kZXggYTgyOGM1 NjlhYS4uMmU3NmUwOGY1NCAxMDA2NDQNCi0tLSBhL2xpc3AvaXNlYXJjaC5l bA0KKysrIGIvbGlzcC9pc2VhcmNoLmVsDQpAQCAtMzA0MCw2ICszMDQwLDEw IEBAIFNlZSBtb3JlIGZvciBvcHRpb25zIGluIGBzZWFyY2gtZXhpdC1vcHRp b24nLiINCiAgICAgICAgICAgIChnb3RvLWNoYXIgaXNlYXJjaC1wcmUtbW92 ZS1wb2ludCkpDQogICAgICAgICAgKGlzZWFyY2gtc2VhcmNoLWFuZC11cGRh dGUpKSkNCiAgICAgIChzZXRxIGlzZWFyY2gtcHJlLW1vdmUtcG9pbnQgbmls KSkNCisgIDs7IFRlcm1pbmF0ZSB0aGUgc2VhcmNoIGlmIHBvaW50IGhhcyBt b3ZlZCB0byBhbm90aGVyIGJ1ZmZlci4NCisgICh1bmxlc3MgKGVxIGlzZWFy Y2gtLWN1cnJlbnQtYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikpDQorICAgICh3 aGVuIChidWZmZXItbGl2ZS1wIGlzZWFyY2gtLWN1cnJlbnQtYnVmZmVyKQ0K KyAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIGlzZWFyY2gtLWN1cnJlbnQt YnVmZmVyIChpc2VhcmNoLWV4aXQpKSkpDQogICAoZm9yY2UtbW9kZS1saW5l LXVwZGF0ZSkpDQogDQogKGRlZnVuIGlzZWFyY2gtcXVvdGUtY2hhciAoJm9w dGlvbmFsIGNvdW50KQ0KLS0gDQoyLjMwLjINCg0K --xT4ooAFDI3--