From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Introducing thread-safe Tramp Date: Sat, 28 Jul 2018 12:59:41 +0300 Message-ID: <3e63b230-6cc1-f517-da71-57b892e14e30@yandex.ru> References: <8736wa9c5s.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1532771872 23908 195.159.176.226 (28 Jul 2018 09:57:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jul 2018 09:57:52 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 To: Michael Albinus , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 28 11:57:47 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjLyq-00063m-KA for ged-emacs-devel@m.gmane.org; Sat, 28 Jul 2018 11:57:44 +0200 Original-Received: from localhost ([::1]:44516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjM0x-000683-FN for ged-emacs-devel@m.gmane.org; Sat, 28 Jul 2018 05:59:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjM0r-00067x-Pw for emacs-devel@gnu.org; Sat, 28 Jul 2018 05:59:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjM0m-0000jz-UH for emacs-devel@gnu.org; Sat, 28 Jul 2018 05:59:49 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:37317) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjM0m-0000ie-Lo for emacs-devel@gnu.org; Sat, 28 Jul 2018 05:59:44 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id j8-v6so5116810lfb.4 for ; Sat, 28 Jul 2018 02:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TefUyOLlXE1zu3AzFxKvOvQfoVsMOZQZCzKA2eieeLQ=; b=TBb4s5cDlGPz0m/dZSBa7BYh9hpddomlk0UD8cRf5ZF3ByKiLHkZSnPvkctlzCQPAW zNOgVmzp/K/2gUtkEs4iDn/3X+YZsSdsada/RklggA2uiyxLc8afs18rBQLeqASAxtnF THnV7eguKREQcmvawggjdWXGv8zrGl9w324VmwSxZiU1y12dOl6kDEU+GyD2270e+S/4 FAVVQiUC64xDNFpj6YtMvC3MAe0PVCUF/WYiwQiPjjd1dWg076GToIpnAZCaZkDycT9J Y1t0cdT4KXyB3x7bzMv2W/AFDIj6hBn43qDNrEbWkPME0X7ySXchn3swtG9HCsq/L8jG 82fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TefUyOLlXE1zu3AzFxKvOvQfoVsMOZQZCzKA2eieeLQ=; b=aHD0wGJOQWEzR8KddbtUp5LLVx8vTNJAaV4qbpZot4T3U+fPA/Vc8OiDFHlMUyvTRb eapAPlKplKR7dPvyDqhZTvZZIBPMhEhgDziMaRN98k4K0hscAATu2dJfO8weiAwAyi7K 37Cw+XbnPRjsdd77bBziHaK83RJaoMYHtYxb465PSzsu/ScUD+8oQovhjSIG7hJsEcp1 e2f+Q7ambQsNj8GUuIKAtXs3Yu0jfGlHh3qudw0gsLNamcRrFBTfhsmStJgWkIyDVnIH JP103fuIjpxBPmUMd4NANVrjPdUQctHeJd50D3Rhb9A0BfMJtgH5pKzYQbcyq3++4+y1 oCFw== X-Gm-Message-State: AOUpUlFZabMOEPR/ekjnDsNTBv721UgPN5TKrcXgdBx5pEbyzCTxAla5 2PPODcaxbQNDnToQ2365eSN7oyzx X-Google-Smtp-Source: AAOMgpcIy+sbBIhAiUisUOu3pKZMfY+KS+RsL+/V3L1JGjN7ge9qhZaFfeWAHp8Y8ssRlofpNXvrMw== X-Received: by 2002:a19:93d2:: with SMTP id w79-v6mr6577381lfk.20.1532771982966; Sat, 28 Jul 2018 02:59:42 -0700 (PDT) Original-Received: from [192.168.1.174] ([178.252.127.223]) by smtp.googlemail.com with ESMTPSA id i1-v6sm1071869ljg.43.2018.07.28.02.59.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jul 2018 02:59:42 -0700 (PDT) In-Reply-To: <8736wa9c5s.fsf@gmx.de> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::12d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227915 Archived-At: On 7/23/18 6:58 PM, Michael Albinus wrote: > As second change, I have modified `vc-refresh-state' to run always in > its own thread. This is because I have observed, that for git > repositories, loading a remote file is often much faster than the > following update of its state in the modeline. For the time being this > behaviour is hard-coded, I haven't seen any drawback for this even for > local files. But we could trigger it also via a user option. > > @Dmitry? No objections from me in principle, but we should probably call vc-file-clearprops right away (is there a chance that some other code calls vc-state before this thread launches and gets stale status?). We could also make vc-state use the same mutex, in order for it to wait until refresh finished, instead of returning the stale result.