From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] em-cmpl: fix completion of command paths Date: Wed, 25 Jan 2023 13:50:39 -0800 Message-ID: <3dad6e29-3041-6164-b862-2e8a90020667@gmail.com> References: <20230107121943.44658-1-nicolas@n16f.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37873"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier , Nicolas Martyanoff Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 25 22:51:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKngD-0009iI-Qb for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Jan 2023 22:51:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKnfL-0001YM-ID; Wed, 25 Jan 2023 16:50:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKnfJ-0001Y8-FZ for emacs-devel@gnu.org; Wed, 25 Jan 2023 16:50:45 -0500 Original-Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKnfH-0007EB-29 for emacs-devel@gnu.org; Wed, 25 Jan 2023 16:50:44 -0500 Original-Received: by mail-pj1-x1035.google.com with SMTP id x2-20020a17090a46c200b002295ca9855aso3505264pjg.2 for ; Wed, 25 Jan 2023 13:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=fN4ucmNZ3EtBwtPKZZDKwQRjsTs5AS/INnAkVNWjP4s=; b=e6wcv79PyKKrtj2fCbQKqoDeWwwIsdYlaAF4wcooJgOP6E9XeWUD5MwLUOr+PvgMqK lC3KQNdof4lSGgHj1lZHwBAHJyuEG0n9ClwI84+aUAlHIwZ3z8QSR2N0A6+31Mhx8R7Z h2Vjq+qK9Snp0t2xDOJHtlI5D2vMcYOrg/elG0D+mQKrASt5rKu4nZnfxHgkh/9/pNT6 mzzAsdctu0V1WNvvcDp4FVfEek5yM7n4a1DhnPV45D8nL2Q+fGnkNOXiuZDUi1aiTJs/ N/PrqYkpOVnTlok+SFLleIQ3fputWwUIGfv9gZqXbTaZdi1I+RvFfDKsTfi1lZgT+k+q FNAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fN4ucmNZ3EtBwtPKZZDKwQRjsTs5AS/INnAkVNWjP4s=; b=rmIVo2luJ1FMJg3KI8YVd4t4f0BLDBCM98L3K05odsyxNhr/IR3o5EAi+DpltcTSAe o6wVJxMgn8jlND2jAv6DFtsbtvbQcWvSS6CYyGibmMdCmopNwSzL3e1dvrdc+cpmyepP 7alWEE0tRqZLTLkI2FuUG22V4Xh0j4/JYoMc7DZ0pO2cPeKK4Sg365KyQLTl6tXnNo8/ TNA/RvWWGY7xRXrukbXYMOZ3wXvk4Jt5ZpZGRFK6GAopFSwdE2nrVtDM4sY+SDMnnHnC sUc9mDrAo3MfI8js2zehOWt7ei4V5srXBwfo1aKMd0BjUZ7N82gnJbEJbM/z0lKVDBfv MW4g== X-Gm-Message-State: AFqh2koHr7dSL5bAN7Q18Pa+TE0NnAkEu0EKmbSs/kegl8U/Ggm2dne6 ZWU6mIntQq/9u+wgNZ5W+UU= X-Google-Smtp-Source: AMrXdXt754lwGcaWLLKCthf8X8KL+BThBFITQmy7EPQdMV0KY9Y3PJM8Re+0CHyLO9nPXwVZQo7Jhw== X-Received: by 2002:a17:903:210d:b0:193:3a92:f4bd with SMTP id o13-20020a170903210d00b001933a92f4bdmr29680339ple.47.1674683441074; Wed, 25 Jan 2023 13:50:41 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id je12-20020a170903264c00b00192588bcce7sm4102316plb.125.2023.01.25.13.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 13:50:40 -0800 (PST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302658 Archived-At: On 1/25/2023 9:03 AM, Stefan Monnier wrote: >> The use of `completion-table-dynamic' was introduced in 899055e to fix >> bug#48995. However the following issue remains: when completing a command >> path, absolute ("/usr/bin/") or relative ("./subdir/"), a space is >> automatically added at the end. >> Bypassing `completion-table-dynamic' for filenames containing a directory >> part fixes the final space bug and does not reintroduce bug#48995. > > This looks very good. > IIUC this fixes a regression w.r.t Emacs-28, so it would be nice to > install it into `emacs-29`. I'm not sure about all the details of this bug, but over in bug#60845, I'm adding some regression tests for completion in Eshell. It probably wouldn't be too hard for someone (possibly me if I have time) to write some regression tests for this command path issue too. Then hopefully this won't cause problems in the future.