From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jefferson Carpenter Newsgroups: gmane.emacs.devel Subject: Re: show-enclosing-scopes Date: Sun, 3 Jun 2018 18:35:54 +0000 Message-ID: <3bfafd57-7163-e3c6-5e4b-0324ed0c63cc@gmail.com> References: <5cb3e5a6-310f-1f2a-ceb8-01b929158ebb@gmail.com> <594F9BDF-F041-4B8D-8425-0BE2AABAA448@gnu.org> <258be7dd-0bf6-f5b1-20d1-08ea65a177e8@gmail.com> <83wow2iamm.fsf@gnu.org> <83o9hehz3c.fsf@gnu.org> <0976c552-b2e7-4f5a-ab66-15dbfb05cbc6@gmail.com> <46170e5a-72d6-b7e2-4b42-40ceee8fca89@gmail.com> <83efi9ibg7.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1528050860 9390 195.159.176.226 (3 Jun 2018 18:34:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2018 18:34:20 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 03 20:34:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPXpX-0002DA-9P for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2018 20:34:15 +0200 Original-Received: from localhost ([::1]:36299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPXrX-0001NW-QK for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2018 14:36:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPXrR-0001NA-Rb for emacs-devel@gnu.org; Sun, 03 Jun 2018 14:36:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPXrQ-0005g5-MZ for emacs-devel@gnu.org; Sun, 03 Jun 2018 14:36:13 -0400 Original-Received: from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]:34976) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPXrQ-0005fj-HS; Sun, 03 Jun 2018 14:36:12 -0400 Original-Received: by mail-io0-x232.google.com with SMTP id u4-v6so11733660iof.2; Sun, 03 Jun 2018 11:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gO3kknYq/91FlrbomeMjdfMZYWsFJAysxrr4+HfIeIE=; b=O5Frn0egorYShuCNTXztKzvgBRS42f5P6tnvlIE5b8YXsfnJdvqF7EHqNZVmktlw1/ F9WbM3FDPW9lgc7vnO6+9i+7OBxEkBH9Xv+6TZiVY+RRKkk/Yfca7kEH/FbySMF1cmKT iYC/E9CAndXsxoKg6d8qP09L/bVz8oKSSi0rFwQ0HlItcDODclBEacr1qpXp26/iVUGi Nw03wTdvXrHVcZy2bc6RE1uBl/719gJxcJz7QB79tVnjK3XRlZO01IX9dUDWx959PZeJ xJKqgXnZE321F6lo1Yhz4ZIntqfHFo04lSKzYVl3q6bqztoxYo7wJmfQOuy72aQ4/zk+ a3TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gO3kknYq/91FlrbomeMjdfMZYWsFJAysxrr4+HfIeIE=; b=QGwIdVcdyJXneWDg5L9//QvqsgQ/z9fbrgceZlUZdzX3gtwsbI7yBeyUs9AJNM02t/ UolVIQ6M0pWDjBz3SUrox7nO93p/4whLVhft+3KCZNo+zKS5jQ5Y8Nodrn3Ya1K39ieO fJg1LQaQeCD+BUHBAYqN0P4RzTKI9qsThqCiddwBcM/Q38DnJ+1LyIfuVOJq/sETkzDi yogSF44Pjyv265bjSJWgMttHDDugOGEfKxitjfuFyOeoHjrq0vGWquWPlBE8ARqRmblD NTgYNsjGcPFsl7ipSgNtYAFxP8tb7itncIEtulrc0KVPG0WRpi0weiPsfiFWhYx7ZMmo 76UQ== X-Gm-Message-State: APt69E1Covu4cubrN5KL5O1ClPb9oz7rXlx3D08DanJcD1UkkYZro+Kj 9CEboa7UYJV4JjpD5rHb1wQ4p9sx X-Google-Smtp-Source: ADUXVKItFFFh4LPSRJOwcuoT3QczWByLhRs+JaNqyfaZQ0nSe3hs2m5sCRb73ID4uBur22DWdbFYJw== X-Received: by 2002:a6b:c7c6:: with SMTP id x189-v6mr18491179iof.262.1528050971395; Sun, 03 Jun 2018 11:36:11 -0700 (PDT) Original-Received: from ?IPv6:2601:441:8680:4631:dd12:fc7d:bd62:9a80? ([2601:441:8680:4631:dd12:fc7d:bd62:9a80]) by smtp.gmail.com with ESMTPSA id e133-v6sm3640542iof.28.2018.06.03.11.36.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jun 2018 11:36:10 -0700 (PDT) In-Reply-To: <83efi9ibg7.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225973 Archived-At: On 5/18/2018 9:02 AM, Eli Zaretskii wrote: > Here, it flickers only in the scroll-bar area, and that is expected, > since you delete the scopes window and then recreate it -- this has to > redraw the scroll bar, and will necessarily flicker. Updated so that it no longer deletes the window and re-creates it quite so many times - namely it no longer requires a pre-command-hook. https://raw.githubusercontent.com/jeffersoncarpenter/emacs.d/master/show-enclosing-scope.el > > Where does it flicker on your system? And what OS is that, with what > toolkit? Good news, it doesn't flicker any more since I removed window deletion in the pre-command-hook. In fact, there are no outstanding bugs as far as I know. (The next step now is to make it more intelligent about what lines to show inside the minimap window. Currently it does it purely based on indentation, which is not optimal in many cases.) > > Btw, you have a bug in show-enclosing-scope--split-window: it doesn't > call set-window-buffer on the "base window", so the fringe, and > probably also the right margin (if it has to be non-empty) are not > redrawn when the window is split. > That's true -- don't tell anyone but I literally copied and pasted the code for creating and deleting the window from sublimity-mode, so I don't know if the code regarding margins and fringes is correct or not in my case. I haven't had a problem with it, but I need to look into it.