From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Pierre_T=C3=A9choueyres?= Newsgroups: gmane.emacs.devel Subject: Re: Add support for base64url variant Date: Wed, 22 May 2019 11:25:34 +0200 Message-ID: <3b0dc49f9831435178dc1b64d6a2f5c7@free.fr> References: <87pnobiglo.fsf@killashandra.ballybran.fr> <837eaj7x37.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="221520"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Webmail Free/1.3.3 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 22 11:27:25 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTNWv-000vVz-5X for ged-emacs-devel@m.gmane.org; Wed, 22 May 2019 11:27:25 +0200 Original-Received: from localhost ([127.0.0.1]:39133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTNWt-00032w-U1 for ged-emacs-devel@m.gmane.org; Wed, 22 May 2019 05:27:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTNVH-0001tP-Lq for emacs-devel@gnu.org; Wed, 22 May 2019 05:25:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTNVG-0003jB-Qb for emacs-devel@gnu.org; Wed, 22 May 2019 05:25:43 -0400 Original-Received: from smtp4-g21.free.fr ([2a01:e0c:1:1599::13]:2602) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTNVE-0003cL-DQ; Wed, 22 May 2019 05:25:40 -0400 Original-Received: from webmail.free.fr (unknown [172.20.243.6]) by smtp4-g21.free.fr (Postfix) with ESMTP id 489B819F5A5; Wed, 22 May 2019 11:25:34 +0200 (CEST) Original-Received: from [194.51.244.51] by webmail.free.fr In-Reply-To: <837eaj7x37.fsf@gnu.org> X-Sender: pierre.techoueyres@free.fr X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:e0c:1:1599::13 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236892 Archived-At: Hello Eli, > > Thanks, but please avoid posting such large patches as long as you > don't have a copyright assignment for Emacs on file. I have already signed paperwork for TRAMP and, I think, for Emacs. But maybe there is something wrong with them ? > That's because > just by reading the patch, people will remember some of the > implementation, and will then have hard time to come up with a > different one, should your copyright assignment paperwork not come > through. > > If you'd like to sign the forms, I will send them to you. Then we > could revisit the patch when the legal paperwork is done. If you can't find my previous assignment, then yes send me them back. > Thanks again for working on this. Hope this could help. I would like to have some discussion on how to improve some points : - Is adding parameter to existing functions the way to go or is it better to add new ones for base64url - I would like to improve base64-decode* in a way it could detect the variant but actually don't know how to do that. - The documentations is not really what I would like to see (and there my English is faulty) Thanks in advance. Pierre.