From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: server.el test failures Date: Fri, 3 Mar 2023 00:00:31 -0800 Message-ID: <3ab787dc-2194-f983-8866-530488d4d9dd@gmail.com> References: <877h40vb8h.fsf@mail.jurta.org> <861qmvcglp.fsf@aarsen.me> <98e880a0-d076-cfd9-b39d-50c84fa8975a@gmail.com> <811d85e0-4032-68df-bc0c-1073ff5d1b96@cs.ucla.edu> <5a38c18d-263c-223b-7335-8395a10eb494@gmail.com> <00864fe6-b63a-685f-2d20-4e1fd5a5573e@cs.ucla.edu> <3e7c26d6-215a-6c29-5304-0e32f42b2174@gmail.com> <87zg8z5afj.fsf@gmail.com> <83ttz7giib.fsf@gnu.org> <87r0ub561t.fsf@gmail.com> <83sfergdgf.fsf@gnu.org> <87h6v6qlq7.fsf@gmail.com> <83ilfmgf88.fsf@gnu.org> <87cz5uq6s1.fsf@gmail.com> <84c54b68-e787-2bc5-0908-52d953b557d2@gmail.com> <83wn41fvc9.fsf@gnu.org> <878rggrict.fsf@gmail.com> <83pm9qco9v.fsf@gnu.org> <2f012e8c-ce15-fd24-d4d5-d744a338a682@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------JPTnq7CeXM3RgMU3bIoBz9Tj" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35513"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 03 09:00:59 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pY0Lb-00093a-3E for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Mar 2023 09:00:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pY0LF-0006KB-Sv; Fri, 03 Mar 2023 03:00:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY0LE-0006Jy-9p for emacs-devel@gnu.org; Fri, 03 Mar 2023 03:00:36 -0500 Original-Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pY0LC-0001HC-GP; Fri, 03 Mar 2023 03:00:36 -0500 Original-Received: by mail-pl1-x630.google.com with SMTP id ky4so1916709plb.3; Fri, 03 Mar 2023 00:00:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677830432; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=RNuKM38LEusuGBWazCF588UWXge3A9vyIjUyN5tT4wU=; b=EiGlXpamFG9jd2i8v9BsyBYlK4UVoTbEwGIUEjoG6+IY6jpXPrmspF2a6E4lyhuHA5 +mIBZrXTjejX8MQaJLj3C1ntBBUk9n5C/P+lvk2z5C5A9VZ5bYgbXk7sdSsBZ2uInAyK HCFpQS5S0VGTk6ne/Unub6UgMM/Yuj6+YuwLFYlLwUxbCMgoIcsjiI3MaPw52oX8XL13 xkX3VM+gxFLNbzXy3H/6XxlA6K0sCcEIf1AFJCDVjXn0StcbLo8IY1n9/P259pLUL/5B cTJFQnJsf0gmB37wcIW1hqJPJd2g6AMBHeIdh/94bMYkkF40djR53LjpLQG8YkEDN/4e xaKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677830432; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RNuKM38LEusuGBWazCF588UWXge3A9vyIjUyN5tT4wU=; b=tVy8/l9H3GGEg2mo3YpVpEuIzOXi1/UjCkwlFMwzlnPttwCBoogNzCAyNtikpOkYTL 5Y81o28tI99uugUumudKT+LuNhHz/cBiTDadWdrPOMdg6QbDON+gJ4yKT2pH7yBEkFs6 pCABC8rqFHzi1U+MCZUNzK6iBYgQgg6ZPeMjtQ8M0l9HOugO+1MW7hP943qGKF0fofEK VSTloZgpiXaRUksDXUv828HtnxLx/ku5TcUi//54n3UCophHScksLbXeRPvOtg7l4djZ /bFvcrLtww+rw7oIcXFBXAubW3s91Emytvis2OcJGkITl48Li1ugcE8rZBKu6aASsaFN Uefg== X-Gm-Message-State: AO0yUKXM6Q0yDAnkFnt0lOr1FqRiH5rHVTr5HMc5JXBIQ3x/zl7Ug6sI l3dMsyrzoK9buZiX0UY6EZ7X0gi7Zu8= X-Google-Smtp-Source: AK7set/9KoDJkzFeZet3CghPJxBnxm90u8X/4l46KDIJaOACIjUWjsazI3U4u0uSYUpSpaUhENYqTw== X-Received: by 2002:a05:6a20:734c:b0:cc:a8d7:ad7e with SMTP id v12-20020a056a20734c00b000cca8d7ad7emr1431254pzc.60.1677830432602; Fri, 03 Mar 2023 00:00:32 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m2-20020a655302000000b004fb3e5681cesm910126pgq.20.2023.03.03.00.00.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 00:00:30 -0800 (PST) Content-Language: en-US In-Reply-To: <2f012e8c-ce15-fd24-d4d5-d744a338a682@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303914 Archived-At: This is a multi-part message in MIME format. --------------JPTnq7CeXM3RgMU3bIoBz9Tj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/2/2023 11:15 PM, Jim Porter wrote: > On 3/2/2023 11:00 PM, Eli Zaretskii wrote: >>> Date: Thu, 2 Mar 2023 14:15:49 -0800 >>> Cc: Eli Zaretskii , eggert@cs.ucla.edu, >>> emacs-devel@gnu.org >>> From: Jim Porter >>> >>> Would that be safe? Since 'parameters' is an argument, we don't actually >>> know how it was created or if modifying in-place would be ok. If it were >>> just a regular quoted list, using 'setf' could cause problems. >> >> If this aspect could be an issue, perhaps it is better to implement >> the change without touching 'parameters' at all?  It isn't hard, it >> just might make the change less elegant and slightly larger. > > Pushing onto the front of 'parameters' should be safe, in the sense that > after 'make-frame' returns, the caller wouldn't be able to tell that we > did anything to it. So long as the caller can't tell, I think it's ok. > > However, there might be a better way to do this anyway; I'll think it over. Ok, I think this is better. Now, instead of messing with 'parameters', when in batch mode, we just always treat the window-system as nil (i.e. create a terminal frame). I ran the server tests with this patch, and they all look good. --------------JPTnq7CeXM3RgMU3bIoBz9Tj Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-create-GUI-frames-in-batch-sessions.patch" Content-Disposition: attachment; filename="0001-Don-t-create-GUI-frames-in-batch-sessions.patch" Content-Transfer-Encoding: base64 RnJvbSAwYzdmOWYwMzhhNWIzZWMyNzQ1NjY5NmFhZmZhOGYwZjQwNDIyNDZlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMjggRmViIDIwMjMgMTE6MzU6MjEgLTA4MDAKU3ViamVjdDogW1BB VENIXSBEb24ndCBjcmVhdGUgR1VJIGZyYW1lcyBpbiBiYXRjaCBzZXNzaW9ucwoKVGhpcyBy ZXNvbHZlcyBhbiBpc3N1ZSB3aXRoIHJ1bm5pbmcgdGVzdC9saXNwL3NlcnZlci10ZXN0cy5l bCB3aGVuCidESVNQTEFZJyBpcyBzZXQ6IHRoZSB0ZXN0cyB3b3VsZCBzdGFydCB0aGUgRW1h Y3Mgc2VydmVyIGluIGEgYmF0Y2gKc2Vzc2lvbiwgYW5kIHRoZW4gcmVxdWVzdCBhIG5ldyBH VUkgZnJhbWUuICBIb3dldmVyLCB0aGF0IGNhdXNlZCB0aGUKdGVzdHMgdG8gdGVybWluYXRl IHdpdGggU0lHSU8sIHNpbmNlIGEgYmF0Y2ggRW1hY3MgZG9lc24ndCBzZXQgYSBTSUdJTwpo YW5kbGVyLgoKUmVmOiA8aHR0cHM6Ly9saXN0cy5nbnUub3JnL2FyY2hpdmUvaHRtbC9lbWFj cy1kZXZlbC8yMDIzLTAyL21zZzAwODc5Lmh0bWw+CgoqIGxpc3AvZnJhbWUuZWwgKG1ha2Ut ZnJhbWUpOiBBbHdheXMgY3JlYXRlIGEgdGVybWluYWwgZnJhbWUgaW4gYmF0Y2gKc2Vzc2lv bnMuCi0tLQogbGlzcC9mcmFtZS5lbCB8IDUgKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2ZyYW1lLmVsIGIvbGlzcC9mcmFtZS5l bAppbmRleCBiODIwZDVmY2Q5Ni4uZDkyNTVhNTUxNzEgMTAwNjQ0Ci0tLSBhL2xpc3AvZnJh bWUuZWwKKysrIGIvbGlzcC9mcmFtZS5lbApAQCAtODczLDYgKzg3MywxMSBAQCBtYWtlLWZy YW1lCiAgIChpbnRlcmFjdGl2ZSkKICAgKGxldCogKChkaXNwbGF5IChjZHIgKGFzc3EgJ2Rp c3BsYXkgcGFyYW1ldGVycykpKQogICAgICAgICAgKHcgKGNvbmQKKyAgICAgICAgICAgICA7 OyBXaGVuIHJ1bm5pbmcgaW4gYSBiYXRjaCBzZXNzaW9uLCBkb24ndCBjcmVhdGUgYSBHVUkK KyAgICAgICAgICAgICA7OyBmcmFtZS4gIChCYXRjaCBzZXNzaW9ucyBkb24ndCBzZXQgYSBT SUdJTyBoYW5kbGVyIG9uCisgICAgICAgICAgICAgOzsgcmVsZXZhbnQgcGxhdGZvcm1zLCBz byBhdHRlbXB0aW5nIHRoaXMgd291bGQgdGVybWluYXRlCisgICAgICAgICAgICAgOzsgRW1h Y3MuKQorICAgICAgICAgICAgIChub25pbnRlcmFjdGl2ZSBuaWwpCiAgICAgICAgICAgICAg KChhc3NxICd0ZXJtaW5hbCBwYXJhbWV0ZXJzKQogICAgICAgICAgICAgICAobGV0ICgodHlw ZSAodGVybWluYWwtbGl2ZS1wCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2RyIChh c3NxICd0ZXJtaW5hbCBwYXJhbWV0ZXJzKSkpKSkKLS0gCjIuMjUuMQoK --------------JPTnq7CeXM3RgMU3bIoBz9Tj--