From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata Date: Tue, 27 Apr 2021 04:46:34 +0300 Message-ID: <3a8d8d52-4b35-4a5a-aefc-db3e11d110e1@yandex.ru> References: <39c93100-a352-538d-717a-663bcc5de296@yandex.ru> <23ebdd80-3ca2-4166-beab-e2535b6cc646@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8860"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: Daniel Mendler , Gregory Heytings , "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 27 03:47:27 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbCow-0002DV-V5 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 03:47:26 +0200 Original-Received: from localhost ([::1]:34162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbCow-0002kk-2Q for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Apr 2021 21:47:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbCoC-00020y-Lc for emacs-devel@gnu.org; Mon, 26 Apr 2021 21:46:40 -0400 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:38721) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbCoA-0004O5-Py for emacs-devel@gnu.org; Mon, 26 Apr 2021 21:46:40 -0400 Original-Received: by mail-wr1-x42b.google.com with SMTP id k14so7848705wrv.5 for ; Mon, 26 Apr 2021 18:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iEgaPs9nrGDMYHfYie4TXe4Lb5r2pfJpVOxWTNzZGXQ=; b=Tu3Qd3PaD3+17mNn9oBPHvsFATAWD/sYgO0Jsowo6fOKHiPgXWL578sX/wCTivMx8R VN+jTPUi2DLFR0KkGdC2vza2yqsghD6locRwbNp5OMU818q2zkdi/hwPa8qLcfpuG5+O zhnWK1vPkUetIK3J0JB12wWvm/MHZQaGmX/p1zjXx/2aFcL0c2460Ci+q2ZF+9E55DKT 1lwjBNLm7pYewCq/6E7mHaMEMqa3AMrvuvS1FqpR55RptNf8L++qHsUtX+cxZYPKbaE2 /g6uzetosALvvUChbKASXflbNwm9bVnEAaR5Kl1AqIOvCdcW8HoCJWtww+yI6CAIEajb JqQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iEgaPs9nrGDMYHfYie4TXe4Lb5r2pfJpVOxWTNzZGXQ=; b=CvbI/LZvt1nS/w5OchQkoxZEl31vL9psx9E8ei0Lv6p6rlt/BKS/rIIvYm2VWS0Wdf jCJvtPjcVza4aeHUI9gEVcjESbd48NjGivSnswgNThA/OSU160zI3yRw4NtRbQ33Xcj8 zM9t08zkcEpYKyuDKm/SpyUzSRfneevtLbvxzzauaRjSn6AAJV64Go9TELlJ2ntUZM5W R0b1VG8OjF9KyzwkxPb6VPZfqQHrF0D/ijrhbByBOStqHp1MsIX9GSQ0LrN40Qn2CeQ7 SGVKNJdjF6DLPCHkN/YzygGWbhxEJOQ/gdh5GuKpfF+2HL3xfH42VeSCt3riR7R8TWWz AFKg== X-Gm-Message-State: AOAM530LXH3c26153RuuBvkzkM8R8HiVogClso91yJcUx4CqbWHYf5cm PJXDLMWsVDnMaeuUSsOHjG8= X-Google-Smtp-Source: ABdhPJzG6VXSAfuuepgWM4GLJfcMqZNI/6/cdw68X57t3B4x9kViwtSd6DFsVgCgdz/MbmoUtklRYw== X-Received: by 2002:a5d:46c7:: with SMTP id g7mr26199016wrs.330.1619487997070; Mon, 26 Apr 2021 18:46:37 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id r5sm6682903wmh.23.2021.04.26.18.46.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 18:46:36 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268508 Archived-At: On 26.04.2021 02:33, Stefan Monnier wrote: >> So it's better if at least icomplete-mode is enabled, preferably with an >> option which shows the completions right away with no input. And the >> vertical style should be even better. > > Maybe we could accommodate this in the default UI by adding an option to > eagerly popup the *Completions* buffer (and keep it updated as long as > it's displayed) and to keep it disabled by default but make it possible > to enable it via completion-category-(overrides|defaults). I don't know if it's enough. And I have my doubts (expressed previously already) about a *Completions* buffer that is impossible to dismiss: it might hide a window showing a buffer you care about. Ultimately, it can be a good change/feature, but it should be championed by somebody actually willing to use the resulting UI on a regular basis. My ideal UI would probably be more like this: https://emacs-lsp.github.io/lsp-ui/images/lsp-xref.gif (though perhaps with a slightly different layout). Meaning, a posframe popup showing the list of all locations, vertically, and a preview popup by its side or below it, displaying the current selected location. Ivy should be easy enough to extend to do that, I think. *Completions* - not so much.