From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: MinGW build broken with O_CLOEXEC undeclared Date: Sun, 8 Mar 2020 01:05:55 -0800 Organization: UCLA Computer Science Department Message-ID: <3a2617d7-9a98-7460-0067-c1227a3131de@cs.ucla.edu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="68193"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 Cc: emacs-devel To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 08 10:11:49 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAryP-000Hf2-4q for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Mar 2020 10:11:49 +0100 Original-Received: from localhost ([::1]:56132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAryO-0001Ku-76 for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Mar 2020 05:11:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54606) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jArxv-0000lK-HY for emacs-devel@gnu.org; Sun, 08 Mar 2020 05:11:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jArxu-0001w2-CM for emacs-devel@gnu.org; Sun, 08 Mar 2020 05:11:19 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jArxu-0001vZ-6v for emacs-devel@gnu.org; Sun, 08 Mar 2020 05:11:18 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B0E3616009E; Sun, 8 Mar 2020 01:05:56 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id obM9zlPARqrD; Sun, 8 Mar 2020 01:05:56 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 08E7F1600AF; Sun, 8 Mar 2020 01:05:56 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kGF0FFlSgphN; Sun, 8 Mar 2020 01:05:55 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D23C716009E; Sun, 8 Mar 2020 01:05:55 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245332 Archived-At: On 3/8/20 12:53 AM, martin rudalics wrote: > Compiling master is currently broken on my Windows XP (MinGW gcc 4.8.1)= as below >=20 > ../../lib/futimens.c:31:1: warning: no previous prototype for 'futimens= '=20 > [-Wmissing-prototypes] > =C2=A0futimens (int fd, struct timespec const times[2]) Yes, I assume this is a consequence of the patch for Bug#39773 being inst= alled. The MinGW port will need to make sure that futimens and utimensat work,=20 presumably by breaking apart fdutimens (which is no longer needed). > ../../lib/open.c:127:49: error: 'O_CLOEXEC' undeclared (first use in th= is function)=20 Did the MinGW port formerly compile open.c? If so, why is O_CLOEXEC undec= lared=20 now when it was declared formerly? If not, why is the MinGW port compilin= g=20 open.c now?