From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Kangas <stefankangas@gmail.com>, dev@rjt.dev, emacs-devel@gnu.org
Subject: Re: More font-lock faces for tree-sitter
Date: Fri, 28 Oct 2022 10:47:28 -0700 [thread overview]
Message-ID: <3FF24BD8-5BAC-4955-8707-B9A3369276C1@gmail.com> (raw)
In-Reply-To: <83bkpwj7a9.fsf@gnu.org>
> On Oct 28, 2022, at 8:29 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Fri, 28 Oct 2022 08:10:31 -0700
>>
>> For example, is there any benefit to adding `font-lock-number-face'?
>> I don't think I've seen many language modes doing that so far. Is there
>> a high demand for it? Is there a big benefit? Personally, I don't feel
>> confident answering that.
>
> Other IDEs do provide this, AFAIR.
>
>> Adding a face, especially a default one, is an implicit invitation to
>> theme developers to use it. If we add too many faces, we risk, in the
>> worst case, seeing a proliferation of angry fruit salad.
>
> That's where fontification levels should come in to give users control
> on how angry their salad is.
>
More font-lock faces would be nice, but hopefully they are not too random (and we don’t bikeshed on them), and new ones should inherit from existing ones, so theme authors don’t need to update their theme.
Yuan
next prev parent reply other threads:[~2022-10-28 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 2:26 More font-lock faces for tree-sitter Randy Taylor
2022-10-28 7:04 ` Eli Zaretskii
2022-10-28 12:48 ` Stefan Monnier
2022-10-28 15:10 ` Stefan Kangas
2022-10-28 15:29 ` Eli Zaretskii
2022-10-28 17:47 ` Yuan Fu [this message]
2022-10-28 15:53 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FF24BD8-5BAC-4955-8707-B9A3369276C1@gmail.com \
--to=casouri@gmail.com \
--cc=dev@rjt.dev \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).