From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Michael Welsh Duggan <md5i@md5i.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
Dmitry Antipov <dmantipov@yandex.ru>,
Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: [RFC] Omit all GCPRO stuff if GC_MAKE_GCPROS_NOOPS
Date: Mon, 16 Jul 2012 15:39:06 +0200 [thread overview]
Message-ID: <3F49C1C3-839B-4274-88EA-86D65C310657@swipnet.se> (raw)
In-Reply-To: <87vchnq3ml.fsf@maru.md5i.com>
16 jul 2012 kl. 14:42 skrev Michael Welsh Duggan:
> Paul Eggert <eggert@cs.ucla.edu> writes:
>
>>> +#define DEFGCPRO1 void *__dummy ATTRIBUTE_UNUSED = &__dummy
>>
>> This would be cleaner if DEFGCPRO1 etc were either empty,
>> or expanded to something that ended in ";". Then the caller
>> can just do "DEFGCPRO1" (without the semicolon) and there's
>> no need for dummy declarations.
>
> This I do not understand. Macros without the semicolons make cc-mode
> have to work much, much harder to determine the current level of
> indentation. I also find it offputting to see something that looks like
> a statement that does not terminate with a semicolon.
>
+1. Actually cc-mode just fails to get indentation level right after such a macro. If on the other hand we would allow declarations after statements, a lone semicolon would not matter.
Jan D.
next prev parent reply other threads:[~2012-07-16 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 17:34 [RFC] Omit all GCPRO stuff if GC_MAKE_GCPROS_NOOPS Dmitry Antipov
2012-07-16 6:41 ` Paul Eggert
2012-07-16 12:42 ` Michael Welsh Duggan
2012-07-16 13:39 ` Jan Djärv [this message]
2012-07-16 14:14 ` Paul Eggert
2012-07-17 7:20 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F49C1C3-839B-4274-88EA-86D65C310657@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=dmantipov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=md5i@md5i.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).