From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: recent emacs font problems? Date: Mon, 09 Jun 2003 14:06:39 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <3EE4784F.70604@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1055160478 3193 80.91.224.249 (9 Jun 2003 12:07:58 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 9 Jun 2003 12:07:58 +0000 (UTC) Cc: rms@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Jun 09 14:07:52 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19PLRI-0000og-00 for ; Mon, 09 Jun 2003 14:07:52 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19PLlI-00053E-00 for ; Mon, 09 Jun 2003 14:28:32 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19PLT9-0001bF-FX for emacs-devel@quimby.gnus.org; Mon, 09 Jun 2003 08:09:47 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19PLSN-00013p-UW for emacs-devel@gnu.org; Mon, 09 Jun 2003 08:08:59 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19PLSC-0000ue-8x for emacs-devel@gnu.org; Mon, 09 Jun 2003 08:08:49 -0400 Original-Received: from stubby.bodenonline.com ([193.201.16.94]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19PLR5-0000Jd-GO; Mon, 09 Jun 2003 08:07:39 -0400 Original-Received: from accessno42.bodenonline.com (accessno42.bodenonline.com [193.201.16.44])h59CujHd023577; Mon, 9 Jun 2003 14:56:47 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030529 X-Accept-Language: en-us, en Original-To: emacs devel X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14952 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14952 Hello. I found out why changing font isn't working. This change did it: @@ -6603,7 +6604,9 @@ frame_font = Fassq (Qfont, f->param_alist); xassert (CONSP (frame_font) && STRINGP (XCDR (frame_font))); frame_font = XCDR (frame_font); - set_lface_from_font_name (f, lface, frame_font, 1, 1); + /* Specify 0 for FORCE_P here, so that we don't override + a :family attribute specified for `default' for new frames. */ + set_lface_from_font_name (f, lface, frame_font, 0, 1); } #endif /* HAVE_WINDOW_SYSTEM */ 2003-05-19 Richard M. Stallman * xfaces.c (Finternal_set_lisp_face_attribute): Handle Qunspecified as value for QCfont attribute. (realize_default_face): lface should already exist; crash if not. Specify 0 for FORCE_P when calling set_lface_from_font_name. The problem is that if FORCE_P is 0, all other attributes of the font won't be set unless they are unspecified in the default face. For exampel size. So if you have a default face font which is fully specified (no undefined parts) no font change will happen. I cant really grasp the problem that lead to this change from the comment above, so if anyone can describe a case for the original problem, I can try and make this work. Jan D.