unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jan D." <jan.h.d@swipnet.se>
Cc: rms@gnu.org
Subject: Re: recent emacs font problems?
Date: Mon, 09 Jun 2003 14:06:39 +0200	[thread overview]
Message-ID: <3EE4784F.70604@swipnet.se> (raw)

Hello.

I found out why changing font isn't working.  This change did it:

@@ -6603,7 +6604,9 @@
        frame_font = Fassq (Qfont, f->param_alist);
        xassert (CONSP (frame_font) && STRINGP (XCDR (frame_font)));
        frame_font = XCDR (frame_font);
-      set_lface_from_font_name (f, lface, frame_font, 1, 1);
+      /* Specify 0 for FORCE_P here, so that we don't override
+        a :family attribute specified for `default' for new frames.  */
+      set_lface_from_font_name (f, lface, frame_font, 0, 1);
      }
  #endif /* HAVE_WINDOW_SYSTEM */

2003-05-19  Richard M. Stallman  <rms@gnu.org>

         * xfaces.c (Finternal_set_lisp_face_attribute): Handle Qunspecified
         as value for QCfont attribute.
         (realize_default_face): lface should already exist; crash if not.
         Specify 0 for FORCE_P when calling set_lface_from_font_name.


The problem is that if FORCE_P is 0, all other attributes of the font won't be 
set unless they are unspecified in the default face.  For exampel size.  So if 
you have a default face font which is fully specified (no undefined parts) no 
font change will happen.

I cant really grasp the problem that lead to this change from the comment 
above, so if anyone can describe a case for the original problem, I can try and 
make this work.

	Jan D.

             reply	other threads:[~2003-06-09 12:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-09 12:06 Jan D. [this message]
2003-06-10  0:17 ` recent emacs font problems? Kim F. Storm
2003-06-10 18:18   ` Jan D.
2003-06-12 14:03     ` Richard Stallman
2003-06-12 16:29       ` Jan D.
2003-06-13 22:03         ` Richard Stallman
2003-06-26 21:32       ` Jan D.
2003-06-26 22:20         ` Sam Steingold
2003-07-07 21:51           ` David Abrahams
2003-07-07 22:16             ` Jason Rumney
2003-07-08 13:40               ` Sam Steingold
2003-07-09  1:31                 ` Miles Bader
2003-07-11 20:33               ` David Abrahams
2003-07-11 21:51                 ` Jason Rumney
2003-06-11  0:24   ` Richard Stallman
2003-06-15 15:59 ` Richard Stallman
  -- strict thread matches above, loose matches on Subject: below --
2003-05-28  1:14 Miles Bader
2003-05-28  4:25 ` Kenichi Handa
2003-05-28  5:14   ` John Paul Wallington
2003-05-28  6:56     ` Miles Bader
2003-05-28 10:16       ` John Paul Wallington
2003-05-28 13:55     ` Richard Stallman
2003-05-30  0:47       ` Kim F. Storm
2003-05-30 17:13         ` Richard Stallman
2003-05-28  5:13 ` Karl Eichwalder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EE4784F.70604@swipnet.se \
    --to=jan.h.d@swipnet.se \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).